diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
commit | bc1407f95bae3d7472ee0c85ef83ee10610b3f1f (patch) | |
tree | eeb1e01423fefc13afe5738d809df200b5e50623 /chrome/browser/automation/ui_controls.h | |
parent | 62525634a6f5727216828f8e05a4f563be90dfeb (diff) | |
download | chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.zip chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.gz chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.bz2 |
Relanding keyboard code refactoring:
http://codereview.chromium.org/248010/show
Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_.
Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly.
BUG=None
TEST=Make sure short-cuts works as expected, especially in the omnibox.
Review URL: http://codereview.chromium.org/251020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/automation/ui_controls.h')
-rw-r--r-- | chrome/browser/automation/ui_controls.h | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/chrome/browser/automation/ui_controls.h b/chrome/browser/automation/ui_controls.h index 7a7a6d6..4613626 100644 --- a/chrome/browser/automation/ui_controls.h +++ b/chrome/browser/automation/ui_controls.h @@ -15,6 +15,7 @@ #include "base/gfx/native_widget_types.h" #include "base/gfx/point.h" +#include "base/keyboard_codes.h" #if defined(TOOLKIT_VIEWS) namespace views { @@ -42,12 +43,17 @@ namespace ui_controls { // these functions, so passing NULL is ok. // Send a key press with/without modifier keys. -// |key| should be a VKEY code as defined in base/keyboard_codes.h -bool SendKeyPress(gfx::NativeWindow window, wchar_t key, bool control, - bool shift, bool alt); -bool SendKeyPressNotifyWhenDone(gfx::NativeWindow window, wchar_t key, - bool control, bool shift, - bool alt, Task* task); +bool SendKeyPress(gfx::NativeWindow window, + base::KeyboardCode key, + bool control, + bool shift, + bool alt); +bool SendKeyPressNotifyWhenDone(gfx::NativeWindow window, + base::KeyboardCode key, + bool control, + bool shift, + bool alt, + Task* task); // Simulate a mouse move. (x,y) are absolute screen coordinates. bool SendMouseMove(long x, long y); |