diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-06 22:45:14 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-06 22:45:14 +0000 |
| commit | 4eaf265da17a1dc133067296ab9a16b519f63bac (patch) | |
| tree | 65cf7ca979067bef262230a66047dbc3b757a0c8 /chrome/browser/automation | |
| parent | a80edd4bf4e8f692fd02a7108a490d7921cc53b9 (diff) | |
| download | chromium_src-4eaf265da17a1dc133067296ab9a16b519f63bac.zip chromium_src-4eaf265da17a1dc133067296ab9a16b519f63bac.tar.gz chromium_src-4eaf265da17a1dc133067296ab9a16b519f63bac.tar.bz2 | |
Handle review comments form previous change. Also, use enum types and not int in IPC messages to make things clearer.
Review URL: http://codereview.chromium.org/20140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9351 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/automation')
| -rw-r--r-- | chrome/browser/automation/automation_provider.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc index 2f7c652..dc1cb10 100644 --- a/chrome/browser/automation/automation_provider.cc +++ b/chrome/browser/automation/automation_provider.cc @@ -2088,16 +2088,16 @@ void AutomationProvider::CreateExternalTab(const IPC::Message& message, void AutomationProvider::NavigateInExternalTab(const IPC::Message& message, int handle, const GURL& url) { - bool status = false; + AutomationMsg_NavigationResponseValues rv = AUTOMATION_MSG_NAVIGATION_ERROR; if (tab_tracker_->ContainsHandle(handle)) { NavigationController* tab = tab_tracker_->GetResource(handle); tab->LoadURL(url, GURL(), PageTransition::TYPED); - status = true; + rv = AUTOMATION_MSG_NAVIGATION_SUCCESS; } Send(new AutomationMsg_NavigateInExternalTabResponse(message.routing_id(), - status)); + rv)); } void AutomationProvider::SetAcceleratorsForTab(const IPC::Message& message, |