diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
| commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
| tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /chrome/browser/automation | |
| parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
| download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/automation')
| -rw-r--r-- | chrome/browser/automation/automation_misc_browsertest.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/automation/testing_automation_provider.cc | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/automation/automation_misc_browsertest.cc b/chrome/browser/automation/automation_misc_browsertest.cc index 97efd95..11ce614 100644 --- a/chrome/browser/automation/automation_misc_browsertest.cc +++ b/chrome/browser/automation/automation_misc_browsertest.cc @@ -82,8 +82,8 @@ IN_PROC_BROWSER_TEST_F(AutomationMiscBrowserTest, ProcessMouseEvent) { " window.didClick = true;" "}, true);")); AutomationMouseEvent automation_event; - automation_event.location_script_chain.push_back( - ScriptEvaluationRequest("{'x': 5, 'y': 10}", "")); + automation_event.location_script_chain + .push_back(ScriptEvaluationRequest("{'x': 5, 'y': 10}", std::string())); WebKit::WebMouseEvent& mouse_event = automation_event.mouse_event; mouse_event.type = WebKit::WebInputEvent::MouseDown; mouse_event.button = WebKit::WebMouseEvent::ButtonLeft; diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc index ae9f48c..e176eec 100644 --- a/chrome/browser/automation/testing_automation_provider.cc +++ b/chrome/browser/automation/testing_automation_provider.cc @@ -991,7 +991,7 @@ void TestingAutomationProvider::GetTabTitle(int handle, NavigationController* tab = tab_tracker_->GetResource(handle); NavigationEntry* entry = tab->GetActiveEntry(); if (entry != NULL) { - *title = UTF16ToWideHack(entry->GetTitleForDisplay("")); + *title = UTF16ToWideHack(entry->GetTitleForDisplay(std::string())); } else { *title = std::wstring(); } @@ -3414,7 +3414,7 @@ void TestingAutomationProvider::RemoveSavedPassword( // This observer will delete itself. PasswordStoreLoginsChangedObserver* observer = new PasswordStoreLoginsChangedObserver( - this, reply_message, PasswordStoreChange::REMOVE, ""); + this, reply_message, PasswordStoreChange::REMOVE, std::string()); observer->Init(); password_store->RemoveLogin(to_remove); @@ -5353,7 +5353,7 @@ void TestingAutomationProvider::GetTabInfo( return; } DictionaryValue dict; - dict.SetString("title", entry->GetTitleForDisplay("")); + dict.SetString("title", entry->GetTitleForDisplay(std::string())); dict.SetString("url", entry->GetVirtualURL().spec()); reply.SendSuccess(&dict); } else { |