summaryrefslogtreecommitdiffstats
path: root/chrome/browser/back_forward_menu_model.cc
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-17 19:04:12 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-17 19:04:12 +0000
commitafe3a16739185a648a21a34e07f3cdb5f1a23c2f (patch)
tree4c82ce550948ed3d67a7a46a1aa066c9080412fb /chrome/browser/back_forward_menu_model.cc
parentd699e3a52d6431ea5d2a691f77866ac8ec7ba350 (diff)
downloadchromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.zip
chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.gz
chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.bz2
Use plain strings instead of wstrings for UMA actions
git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/back_forward_menu_model.cc')
-rw-r--r--chrome/browser/back_forward_menu_model.cc18
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/back_forward_menu_model.cc b/chrome/browser/back_forward_menu_model.cc
index e7b6d68..43f4b31 100644
--- a/chrome/browser/back_forward_menu_model.cc
+++ b/chrome/browser/back_forward_menu_model.cc
@@ -164,7 +164,7 @@ void BackForwardMenuModel::ExecuteCommandById(int menu_id) {
// Execute the command for the last item: "Show Full History".
if (menu_id == GetTotalItemCount()) {
- UserMetrics::RecordComputedAction(BuildActionName(L"ShowFullHistory", -1),
+ UserMetrics::RecordComputedAction(BuildActionName("ShowFullHistory", -1),
controller.profile());
browser_->ShowSingleDOMUITab(GURL(chrome::kChromeUIHistoryURL));
return;
@@ -173,10 +173,10 @@ void BackForwardMenuModel::ExecuteCommandById(int menu_id) {
// Log whether it was a history or chapter click.
if (menu_id <= GetHistoryItemCount()) {
UserMetrics::RecordComputedAction(
- BuildActionName(L"HistoryClick", menu_id), controller.profile());
+ BuildActionName("HistoryClick", menu_id), controller.profile());
} else {
UserMetrics::RecordComputedAction(
- BuildActionName(L"ChapterClick", menu_id - GetHistoryItemCount() - 1),
+ BuildActionName("ChapterClick", menu_id - GetHistoryItemCount() - 1),
controller.profile());
}
@@ -284,17 +284,17 @@ NavigationEntry* BackForwardMenuModel::GetNavigationEntry(int menu_id) const {
return GetTabContents()->controller().GetEntryAtIndex(index);
}
-std::wstring BackForwardMenuModel::BuildActionName(
- const std::wstring& action, int index) const {
+std::string BackForwardMenuModel::BuildActionName(
+ const std::string& action, int index) const {
DCHECK(!action.empty());
DCHECK(index >= -1);
- std::wstring metric_string;
+ std::string metric_string;
if (model_type_ == FORWARD_MENU)
- metric_string += L"ForwardMenu_";
+ metric_string += "ForwardMenu_";
else
- metric_string += L"BackMenu_";
+ metric_string += "BackMenu_";
metric_string += action;
if (index != -1)
- metric_string += IntToWString(index);
+ metric_string += IntToString(index);
return metric_string;
}