diff options
| author | horo <horo@chromium.org> | 2016-01-25 06:36:45 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-25 14:38:04 +0000 |
| commit | 9638ad271db786762315556b7c2bc9c0a55c8e76 (patch) | |
| tree | 3d4d25e42153b553a345935b203188256eea786c /chrome/browser/banners/app_banner_data_fetcher_desktop.h | |
| parent | f5cdfde9135883c6cd83c81436ebe4888c432b8b (diff) | |
| download | chromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.zip chromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.tar.gz chromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.tar.bz2 | |
Add "Request app banner" context menu in DevTools
BUG=540491
Demo: https://drive.google.com/file/d/0B6skYAFVnosEc1RQRm9KYmxCeXM/view?usp=sharing
When the user clicks "Request app banner" context menu, Chrome tries to open
"add to homescreen" banner. And if error happens, it will show the detailed
information about why the app banner is not opened even if
"bypass-app-banner-engagement-checks" flag is not set.
RequestAppBanner method from DevTools is handled like this:
Android:
PageHandler::RequestAppBanner()
-> TabWebContentsDelegateAndroid::RequestAppBanner()
-> Java TabWebContentsDelegateAndroid.requestAppBanner()
-> Java Tab.requestAppBanner()
-> Java AppBannerManager.requestAppBanner()
-> nativeRequestAppBanner()
-> AppBannerManagerAndroid::RequestAppBanner()
-> AppBannerManager::TriggerAppBannerFetch()
Desktop:
PageHandler::RequestAppBanner()
-> Browser::RequestAppBanner()
-> AppBannerManager::TriggerAppBannerFetch()
Review URL: https://codereview.chromium.org/1569893003
Cr-Commit-Position: refs/heads/master@{#371239}
Diffstat (limited to 'chrome/browser/banners/app_banner_data_fetcher_desktop.h')
| -rw-r--r-- | chrome/browser/banners/app_banner_data_fetcher_desktop.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/banners/app_banner_data_fetcher_desktop.h b/chrome/browser/banners/app_banner_data_fetcher_desktop.h index 1915e880..3bef84a 100644 --- a/chrome/browser/banners/app_banner_data_fetcher_desktop.h +++ b/chrome/browser/banners/app_banner_data_fetcher_desktop.h @@ -22,7 +22,8 @@ class AppBannerDataFetcherDesktop : public AppBannerDataFetcher { AppBannerDataFetcherDesktop(content::WebContents* web_contents, base::WeakPtr<Delegate> weak_delegate, int ideal_icon_size_in_dp, - int minimum_icon_size_in_dp); + int minimum_icon_size_in_dp, + bool is_debug_mode); // Callback for finishing bookmark app creation void FinishCreateBookmarkApp(const extensions::Extension* extension, |