summaryrefslogtreecommitdiffstats
path: root/chrome/browser/banners/app_banner_manager_desktop.cc
diff options
context:
space:
mode:
authorhoro <horo@chromium.org>2016-01-25 06:36:45 -0800
committerCommit bot <commit-bot@chromium.org>2016-01-25 14:38:04 +0000
commit9638ad271db786762315556b7c2bc9c0a55c8e76 (patch)
tree3d4d25e42153b553a345935b203188256eea786c /chrome/browser/banners/app_banner_manager_desktop.cc
parentf5cdfde9135883c6cd83c81436ebe4888c432b8b (diff)
downloadchromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.zip
chromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.tar.gz
chromium_src-9638ad271db786762315556b7c2bc9c0a55c8e76.tar.bz2
Add "Request app banner" context menu in DevTools
BUG=540491 Demo: https://drive.google.com/file/d/0B6skYAFVnosEc1RQRm9KYmxCeXM/view?usp=sharing When the user clicks "Request app banner" context menu, Chrome tries to open "add to homescreen" banner. And if error happens, it will show the detailed information about why the app banner is not opened even if "bypass-app-banner-engagement-checks" flag is not set. RequestAppBanner method from DevTools is handled like this: Android: PageHandler::RequestAppBanner() -> TabWebContentsDelegateAndroid::RequestAppBanner() -> Java TabWebContentsDelegateAndroid.requestAppBanner() -> Java Tab.requestAppBanner() -> Java AppBannerManager.requestAppBanner() -> nativeRequestAppBanner() -> AppBannerManagerAndroid::RequestAppBanner() -> AppBannerManager::TriggerAppBannerFetch() Desktop: PageHandler::RequestAppBanner() -> Browser::RequestAppBanner() -> AppBannerManager::TriggerAppBannerFetch() Review URL: https://codereview.chromium.org/1569893003 Cr-Commit-Position: refs/heads/master@{#371239}
Diffstat (limited to 'chrome/browser/banners/app_banner_manager_desktop.cc')
-rw-r--r--chrome/browser/banners/app_banner_manager_desktop.cc7
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/banners/app_banner_manager_desktop.cc b/chrome/browser/banners/app_banner_manager_desktop.cc
index d3aa3bf..01b8e80 100644
--- a/chrome/browser/banners/app_banner_manager_desktop.cc
+++ b/chrome/browser/banners/app_banner_manager_desktop.cc
@@ -31,10 +31,11 @@ bool AppBannerManagerDesktop::IsEnabled() {
}
AppBannerDataFetcher* AppBannerManagerDesktop::CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate) {
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
+ bool is_debug_mode) {
return new AppBannerDataFetcherDesktop(web_contents(), weak_delegate,
- kMinimumIconSize,
- kMinimumIconSize);
+ kMinimumIconSize, kMinimumIconSize,
+ is_debug_mode);
}
AppBannerManagerDesktop::AppBannerManagerDesktop(