diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-03 16:47:10 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-03 16:47:10 +0000 |
| commit | bdc586d588b98b249e675b1d7c5493bb576a916e (patch) | |
| tree | 9241bb3fd0a7ad7e863dbb5f926d2125b72f7f63 /chrome/browser/blocked_popup_container.h | |
| parent | 5590b304d9f814e7be2f867270e962e582a48a34 (diff) | |
| download | chromium_src-bdc586d588b98b249e675b1d7c5493bb576a916e.zip chromium_src-bdc586d588b98b249e675b1d7c5493bb576a916e.tar.gz chromium_src-bdc586d588b98b249e675b1d7c5493bb576a916e.tar.bz2 | |
Rewrite chunks of the blocked popup container code:
* Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups.
* Be clearer and stricter about item indexes and sanity checking. Hopefully, this or the previous item fix a crash we saw (no bug filed).
* Add notice support (as much as exists for Windows) to GTK and Mac.
* Make the implementations in the three platforms mirror each other a little more precisely.
* Fix (expected, actual) mis-ordering in Mac unittest.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27949 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/blocked_popup_container.h')
| -rw-r--r-- | chrome/browser/blocked_popup_container.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/blocked_popup_container.h b/chrome/browser/blocked_popup_container.h index 155d648..7eb6192 100644 --- a/chrome/browser/blocked_popup_container.h +++ b/chrome/browser/blocked_popup_container.h @@ -114,12 +114,13 @@ class BlockedPopupContainer : public TabContentsDelegate, // Returns the number of blocked notices, popups don't count. size_t GetBlockedNoticeCount() const; - // Returns true if host |index| is whitelisted. Returns false if |index| is - // invalid. + // Returns true if host |index| is whitelisted. + // NOTE: Does not sanity-check; do not pass an invalid index! bool IsHostWhitelisted(size_t index) const; // If host |index| is currently whitelisted, un-whitelists it. Otherwise, // whitelists it and opens all blocked popups from it. + // NOTE: Does not sanity-check; do not pass an invalid index! void ToggleWhitelistingForHost(size_t index); // Deletes all popups and hides the interface parts. |