diff options
author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
---|---|---|
committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
commit | 7f856bee73ffdccdbbbbbab4cb79185290d38359 (patch) | |
tree | a837328e08a113abdc70b2fc0ae2f2a4a3f804eb /chrome/browser/bookmark_bar_context_menu_controller.h | |
parent | 281fe14063dd8fb81cea102f5abb7b82f407c3d1 (diff) | |
download | chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.zip chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.gz chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.bz2 |
First cut at the bookmark manager. There are still a fair number of
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmark_bar_context_menu_controller.h')
-rw-r--r-- | chrome/browser/bookmark_bar_context_menu_controller.h | 59 |
1 files changed, 0 insertions, 59 deletions
diff --git a/chrome/browser/bookmark_bar_context_menu_controller.h b/chrome/browser/bookmark_bar_context_menu_controller.h deleted file mode 100644 index e6227cd..0000000 --- a/chrome/browser/bookmark_bar_context_menu_controller.h +++ /dev/null @@ -1,59 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_BOOKMARK_BAR_CONTEXT_MENU_CONTROLLER_H_ -#define CHROME_BROWSER_BOOKMARK_BAR_CONTEXT_MENU_CONTROLLER_H_ - -#include "chrome/views/chrome_menu.h" -#include "chrome/browser/views/bookmark_bar_view.h" -#include "webkit/glue/window_open_disposition.h" - -class BookmarkNode; -class PageNavigator; - -// BookmarkBarContextMenuController manages the context menus shown for the -// bookmark bar, items on the bookmark bar, and submens of folders on the -// bookmark bar. -class BookmarkBarContextMenuController : public views::MenuDelegate, - public BookmarkBarView::ModelChangedListener { - public: - // Recursively opens all bookmarks of |node|. |initial_disposition| dictates - // how the first URL is opened, all subsequent URLs are opened as background - // tabs. - static void OpenAll(HWND parent, - PageNavigator* navigator, - BookmarkNode* node, - WindowOpenDisposition initial_disposition); - - BookmarkBarContextMenuController(BookmarkBarView* view, - BookmarkNode* node); - - // Shows the menu at the specified place. - void RunMenuAt(int x, int y); - - // ModelChangedListener method, cancels the menu. - virtual void ModelChanged(); - - // Returns the menu. - views::MenuItemView* menu() { return &menu_; } - - // Menu::Delegate methods. - virtual void ExecuteCommand(int id); - virtual bool IsItemChecked(int id) const; - virtual bool IsCommandEnabled(int id) const; - - private: - // Returns the parent node and visual_order to use when adding new - // bookmarks/folders. - BookmarkNode* GetParentAndVisualOrderForNewNode(int* visual_order); - - views::MenuItemView menu_; - BookmarkBarView* view_; - BookmarkNode* node_; - - DISALLOW_EVIL_CONSTRUCTORS(BookmarkBarContextMenuController); -}; - -#endif // CHROME_BROWSER_BOOKMARK_BAR_CONTEXT_MENU_CONTROLLER_H_ - |