diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-05 02:44:51 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-05 02:44:51 +0000 |
| commit | 3de6fd34b8081868e0476341987c8953fd1cfba4 (patch) | |
| tree | 5c55943a94a1edb6a744d75b5389c68f38f81557 /chrome/browser/bookmark_bar_model.h | |
| parent | f052118e0a1dea89270f0c92cb78d8b277720dc6 (diff) | |
| download | chromium_src-3de6fd34b8081868e0476341987c8953fd1cfba4.zip chromium_src-3de6fd34b8081868e0476341987c8953fd1cfba4.tar.gz chromium_src-3de6fd34b8081868e0476341987c8953fd1cfba4.tar.bz2 | |
Attempt at fixing crash. I believe this is happening during session
end, which has a different shutdown path and is possible for the model
to be deleted before the view.
I'm also adding checking to XPFrame/VistaFrame to make sure the
BookmarkBarView doesn't have a parent in the destructor. This
shouldn't be possible, but I'm adding the check to be sure;)
BUG=1359852
TEST=make sure you don't see problems with bookmarks
Review URL: http://codereview.chromium.org/440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmark_bar_model.h')
| -rw-r--r-- | chrome/browser/bookmark_bar_model.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/bookmark_bar_model.h b/chrome/browser/bookmark_bar_model.h index a15bb67..0bcbdf0 100644 --- a/chrome/browser/bookmark_bar_model.h +++ b/chrome/browser/bookmark_bar_model.h @@ -128,6 +128,9 @@ class BookmarkBarModelObserver { // Invoked when the model has finished loading. virtual void Loaded(BookmarkBarModel* model) = 0; + // Invoked from the destructor of the BookmarkBarModel. + virtual void BookmarkModelBeingDeleted(BookmarkBarModel* model) { } + // Invoked when a node has moved. virtual void BookmarkNodeMoved(BookmarkBarModel* model, BookmarkBarNode* old_parent, |