diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 17:20:01 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 17:20:01 +0000 |
commit | 6696502bf689f978da3b89c076212204829a4c5d (patch) | |
tree | 2930685f69f651777f03710bfc82808d684f7184 /chrome/browser/bookmarks/bookmark_model.h | |
parent | 9670691da1ff13fc4c0cd69fab4369b448f9019a (diff) | |
download | chromium_src-6696502bf689f978da3b89c076212204829a4c5d.zip chromium_src-6696502bf689f978da3b89c076212204829a4c5d.tar.gz chromium_src-6696502bf689f978da3b89c076212204829a4c5d.tar.bz2 |
Lands http://codereview.chromium.org/155428 for Thiago, which changes
from me to get the thing to work.
Merging two versions of BookmarkNodeRemoved into one.
BUG=None
TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure
everything works ok.
Review URL: http://codereview.chromium.org/155572
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmarks/bookmark_model.h')
-rw-r--r-- | chrome/browser/bookmarks/bookmark_model.h | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h index c8ba083..4157089 100644 --- a/chrome/browser/bookmarks/bookmark_model.h +++ b/chrome/browser/bookmarks/bookmark_model.h @@ -181,16 +181,14 @@ class BookmarkModelObserver { int index) = 0; // Invoked when a node has been removed, the item may still be starred though. - // TODO(sky): merge these two into one. - virtual void BookmarkNodeRemoved(BookmarkModel* model, - const BookmarkNode* parent, - int index) {} + // |parent| the parent of the node that was removed. + // |old_index| the index of the removed node in |parent| before it was + // removed. + // |node| is the node that was removed. virtual void BookmarkNodeRemoved(BookmarkModel* model, const BookmarkNode* parent, int old_index, - const BookmarkNode* node) { - BookmarkNodeRemoved(model, parent, old_index); - } + const BookmarkNode* node) = 0; // Invoked when the title or favicon of a node has changed. virtual void BookmarkNodeChanged(BookmarkModel* model, |