diff options
| author | skrul@chromium.org <skrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 01:05:06 +0000 |
|---|---|---|
| committer | skrul@chromium.org <skrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 01:05:06 +0000 |
| commit | 1a566fae85db2780b4771432584ab6341eafdfb9 (patch) | |
| tree | 1532d88e6b4311abef11ee99781d08c73628c45d /chrome/browser/bookmarks | |
| parent | 2e0ad4ae783113c1109b5c98fe4104a220c0b839 (diff) | |
| download | chromium_src-1a566fae85db2780b4771432584ab6341eafdfb9.zip chromium_src-1a566fae85db2780b4771432584ab6341eafdfb9.tar.gz chromium_src-1a566fae85db2780b4771432584ab6341eafdfb9.tar.bz2 | |
Remove extra notification from BookmarkModel::Copy.
This was causing duplicate bookmarks to be created in the sync database when a mac user uses option drag to duplicate a bookmark.
I have not run this yet on a mac to make sure it works, but I am in progress of compiling on my macbook :)
BUG=41398
TEST=unittest
Review URL: http://codereview.chromium.org/1599035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44730 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmarks')
| -rw-r--r-- | chrome/browser/bookmarks/bookmark_model.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc index cf9f653..be78ef5 100644 --- a/chrome/browser/bookmarks/bookmark_model.cc +++ b/chrome/browser/bookmarks/bookmark_model.cc @@ -223,13 +223,12 @@ void BookmarkModel::Copy(const BookmarkNode* node, SetDateGroupModified(new_parent, Time::Now()); BookmarkDragData drag_data_(node); std::vector<BookmarkDragData::Element> elements(drag_data_.elements); + // CloneDragData will use BookmarkModel methods to do the job, so we + // don't need to send notifications here. bookmark_utils::CloneDragData(this, elements, new_parent, index); if (store_.get()) store_->ScheduleSave(); - - FOR_EACH_OBSERVER(BookmarkModelObserver, observers_, - BookmarkNodeAdded(this, new_parent, index)); } const SkBitmap& BookmarkModel::GetFavIcon(const BookmarkNode* node) { |