diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-14 20:51:16 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-14 20:51:16 +0000 |
| commit | a4ed6281fe6d6aad1366a8f6b03e35f6e1eadaa6 (patch) | |
| tree | d99e2aaa6ee7d542278756feb4006ec0e38d1a45 /chrome/browser/browser.cc | |
| parent | 87130f869a23f9a842f3a25212dd37bf29814c9d (diff) | |
| download | chromium_src-a4ed6281fe6d6aad1366a8f6b03e35f6e1eadaa6.zip chromium_src-a4ed6281fe6d6aad1366a8f6b03e35f6e1eadaa6.tar.gz chromium_src-a4ed6281fe6d6aad1366a8f6b03e35f6e1eadaa6.tar.bz2 | |
Fix extension shutdown notification, take 2.
The first patch was broken because a lot of stuff relied on the EXTENSION_PROCESS_CRASHED notification being sent when the extension hadn't actually "crashed". New fix: rename the notification to EXTENSION_PROCESS_TERMINATED, and don't send unload notifications during browser shutdown.
BUG=30057
Review URL: http://codereview.chromium.org/489009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34489 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser.cc')
| -rw-r--r-- | chrome/browser/browser.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc index 40690ba..0c892a9 100644 --- a/chrome/browser/browser.cc +++ b/chrome/browser/browser.cc @@ -155,7 +155,7 @@ Browser::Browser(Type type, Profile* profile) NotificationService::AllSources()); registrar_.Add(this, NotificationType::EXTENSION_UNLOADED_DISABLED, NotificationService::AllSources()); - registrar_.Add(this, NotificationType::EXTENSION_PROCESS_CRASHED, + registrar_.Add(this, NotificationType::EXTENSION_PROCESS_TERMINATED, NotificationService::AllSources()); registrar_.Add(this, NotificationType::BROWSER_THEME_CHANGED, NotificationService::AllSources()); @@ -2375,7 +2375,7 @@ void Browser::Observe(NotificationType type, break; } - case NotificationType::EXTENSION_PROCESS_CRASHED: { + case NotificationType::EXTENSION_PROCESS_TERMINATED: { window()->GetLocationBar()->InvalidatePageActions(); TabContents* tab_contents = GetSelectedTabContents(); |