Only show gray LOADING dialog for Themes.

The patch changes the behavior of the LOADING dialog such that it is only shown for extension downloads from the mini-gallery (theme) url. Note that this means that themes from the chrome extensions gallery will also NOT have the dialog shown.

BUG=29628
TEST=Install an theme from https://tools.google.com/chrome/intl/pt/themes/index.html. The gray LOADING dialog should appear. Install extension or theme from chrome.google.com/extensions. No LOADING dialog should appear

Review URL: http://codereview.chromium.org/507016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34733 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 1 deletions

diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index 0868c7b..52eedad 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -2396,7 +2396,14 @@ void Browser::Observe(NotificationType type,
     case NotificationType::EXTENSION_READY_FOR_INSTALL: {
       if (BrowserList::GetLastActive() != this)
         break;
-      window()->ShowThemeInstallBubble();
+
+      // We only want to show the loading dialog for themes, but we don't want
+      // to wait until unpack to find out an extension is a theme, so we test
+      // the download_url GURL instead. This means that themes in the extensions
+      // gallery won't get the loading dialog.
+      GURL download_url = *(Details<GURL>(details).ptr());
+      if (ExtensionsService::IsDownloadFromMiniGallery(download_url))
+        window()->ShowThemeInstallBubble();
       break;
     }