Remove attempt to be smart about where to open navigations

targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.

Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.

In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.

BUG=52680

Review URL: http://codereview.chromium.org/3161037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 14 deletions

diff --git a/chrome/browser/browser.h b/chrome/browser/browser.h
index 4c99238..5f9a23c 100644
--- a/chrome/browser/browser.h
+++ b/chrome/browser/browser.h
@@ -621,7 +621,6 @@ class Browser : public TabStripModelDelegate,
   virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
 
  private:
-  FRIEND_TEST_ALL_PREFIXES(BrowserTest, PinnedTabDisposition);
   FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups);
 
   // Used to describe why a tab is being detached. This is used by
@@ -637,8 +636,6 @@ class Browser : public TabStripModelDelegate,
     DETACH_TYPE_EMPTY
   };
 
-  bool IsPinned(TabContents* source);
-
   // Overridden from TabStripModelDelegate:
   virtual TabContents* AddBlankTab(bool foreground);
   virtual TabContents* AddBlankTabAt(int index, bool foreground);
@@ -950,17 +947,6 @@ class Browser : public TabStripModelDelegate,
   // cancel closing of window.
   bool IsClosingPermitted();
 
-  // Calculate a new window open disposition for a navigation. The return
-  // value will usually be |original_disposition|, but for some pinned tab cases
-  // we change it to NEW_FOREGROUND_TAB so that the pinned tab feels more
-  // permanent.
-  static WindowOpenDisposition AdjustWindowOpenDispositionForTab(
-      bool is_pinned,
-      const GURL& url,
-      const GURL& referrer,
-      PageTransition::Type transition,
-      WindowOpenDisposition original_disposition);
-
   // Data members /////////////////////////////////////////////////////////////
 
   NotificationRegistrar registrar_;