diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-30 17:11:10 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-30 17:11:10 +0000 |
| commit | 940ccb2c357f17b2727b92999491cd4e0e25d0b4 (patch) | |
| tree | 19b441db80d298393f5bacaddb5e4c50642c6f50 /chrome/browser/browser.h | |
| parent | 7f74a4ee8538089c11895ff2f3b7110f3ca0061b (diff) | |
| download | chromium_src-940ccb2c357f17b2727b92999491cd4e0e25d0b4.zip chromium_src-940ccb2c357f17b2727b92999491cd4e0e25d0b4.tar.gz chromium_src-940ccb2c357f17b2727b92999491cd4e0e25d0b4.tar.bz2 | |
Relanding this, it was missing the Mac unit-test change, that was breaking the build.
TBR=ben
Closing the last tab with a download in-progress would cause the tab to be
closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.
This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.
BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.
Review URL: http://codereview.chromium.org/100210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser.h')
| -rw-r--r-- | chrome/browser/browser.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/browser.h b/chrome/browser/browser.h index b59d4ff..d89337c 100644 --- a/chrome/browser/browser.h +++ b/chrome/browser/browser.h @@ -432,6 +432,7 @@ class Browser : public TabStripModelDelegate, virtual void CloseFrameAfterDragSession(); virtual void CreateHistoricalTab(TabContents* contents); virtual bool RunUnloadListenerBeforeClosing(TabContents* contents); + virtual bool CanCloseContentsAt(int index); // Overridden from TabStripModelObserver: virtual void TabInsertedAt(TabContents* contents, |