diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-06 03:32:12 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-06 03:32:12 +0000 |
| commit | 807e90d8ea383e85645ad33522e9f9e17a9f25f3 (patch) | |
| tree | cdac30c9e09e0c4cacf9694eeabb650c6f5bcce1 /chrome/browser/browser_about_handler.cc | |
| parent | 260cdeef79ce2e2a641a981de51b6d35b758422a (diff) | |
| download | chromium_src-807e90d8ea383e85645ad33522e9f9e17a9f25f3.zip chromium_src-807e90d8ea383e85645ad33522e9f9e17a9f25f3.tar.gz chromium_src-807e90d8ea383e85645ad33522e9f9e17a9f25f3.tar.bz2 | |
Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windows
specific code for the settings dialog and the table view are just copied from
the old dialog. I tried to change as little as possible. The only significant
change should be that I commented out saving the settings in the profile.
This is a re-land of my previous patch which didn't ifdef the code based on the
IPC logging preprocessor define.
Previous review URL: http://codereview.chromium.org/19741
Review URL: http://codereview.chromium.org/20033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9303 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_about_handler.cc')
| -rw-r--r-- | chrome/browser/browser_about_handler.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc index a9028d7..0ca3435 100644 --- a/chrome/browser/browser_about_handler.cc +++ b/chrome/browser/browser_about_handler.cc @@ -25,7 +25,7 @@ #include "chrome/browser/profile_manager.h" #include "chrome/browser/renderer_host/render_process_host.h" #include "chrome/browser/renderer_host/render_view_host.h" -#include "chrome/browser/tab_contents/ipc_status_view.h" +#include "chrome/browser/views/about_ipc_dialog.h" #include "chrome/common/jstemplate_builder.h" #include "chrome/common/l10n_util.h" #include "chrome/common/pref_names.h" @@ -184,11 +184,11 @@ bool BrowserAboutHandler::MaybeHandle(GURL* url, } #ifdef IPC_MESSAGE_LOG_ENABLED - if ((LowerCaseEqualsASCII(url->path(), "ipc")) && - (IPCStatusView::current() == NULL)) { - // about:ipc doesn't have an internal protocol, so don't modify |url|. - *result_type = TAB_CONTENTS_IPC_STATUS_VIEW; - return true; + if (LowerCaseEqualsASCII(url->path(), "ipc")) { + // Run the dialog. This will re-use the existing one if it's already up. + AboutIPCDialog::RunDialog(); + *url = GURL("about:blank"); + return false; } #endif |