diff options
| author | andresantoso <andresantoso@chromium.org> | 2014-12-18 14:37:55 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-18 22:38:53 +0000 |
| commit | 063151db25bcb19a73e5eff7794f317c18c055d5 (patch) | |
| tree | ed862c494a6b34d8cf29fcaadc9619c271164e63 /chrome/browser/browser_about_handler.cc | |
| parent | e06ea3d8d0d0978001b5fc1f6a54c4665e0e82a7 (diff) | |
| download | chromium_src-063151db25bcb19a73e5eff7794f317c18c055d5.zip chromium_src-063151db25bcb19a73e5eff7794f317c18c055d5.tar.gz chromium_src-063151db25bcb19a73e5eff7794f317c18c055d5.tar.bz2 | |
MacViews: Make a factory for tab dialogs.
We were using global functions to invoke platform-specific dialogs from
cross-platform call sites.
With MacViews, we have a problem with these functions getting 2 definitions.
Rather than using ifdefs, this change attaches an abstract factory object to
web contents to avoid multiple definitions and ensure that a Views browser
would invoke Views dialogs and a Cocoa browser would invoke Cocoa dialogs.
BUG=425229
Review URL: https://codereview.chromium.org/806483003
Cr-Commit-Position: refs/heads/master@{#309093}
Diffstat (limited to 'chrome/browser/browser_about_handler.cc')
| -rw-r--r-- | chrome/browser/browser_about_handler.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc index a01735f..7d19585 100644 --- a/chrome/browser/browser_about_handler.cc +++ b/chrome/browser/browser_about_handler.cc @@ -6,7 +6,9 @@ #include <string> +#include "base/bind.h" #include "base/logging.h" +#include "base/message_loop/message_loop.h" #include "base/strings/string_util.h" #include "chrome/browser/lifetime/application_lifetime.h" #include "chrome/browser/ui/browser_dialogs.h" |