diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-10 15:26:34 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-10 15:26:34 +0000 |
| commit | 248ce19f35b73cdd48ba005c7e4e7b3bc34817fc (patch) | |
| tree | 25352120ffe0b8f01e1b0a3c5109e3f9fc35704e /chrome/browser/browser_about_handler.h | |
| parent | 262e8693478039b0d2e786938cffc476ee102a0a (diff) | |
| download | chromium_src-248ce19f35b73cdd48ba005c7e4e7b3bc34817fc.zip chromium_src-248ce19f35b73cdd48ba005c7e4e7b3bc34817fc.tar.gz chromium_src-248ce19f35b73cdd48ba005c7e4e7b3bc34817fc.tar.bz2 | |
Attempt 3 at: Splits ChromeURLDataManager into 2 chunks:
. ChromeURLDataManager is no longer a singleton and is always used on
the UI thread. ChromeURLDataManager is now profile specific (you get
from the profile).
. ChromeURLDataManagerBackend handles the URLRequests and the
DataSources. ChromeURLDataManagerBackend is created by
ChromeURLRequestContext.
All DataSources are now profile specific. There were two that wanted
to be global, but have been converted.
This differs from the last version in that DataSource::SendResponse
does nothing if the DataSource is schedule for deletion. This is
necessary otherwise SendResponse will up the ref count and by the time
the request is processed on the IO thread chances are the DataSource
will have been deleted. And if it wasn't deleted, it'll get scheduled
for deletion again. <insert comment here about the perils of using
delayed deletion> This has always been possible, it just appears to be
more likely with my patch.
BUG=52022 71868
TEST=none
Review URL: http://codereview.chromium.org/6479007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74432 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_about_handler.h')
| -rw-r--r-- | chrome/browser/browser_about_handler.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/browser_about_handler.h b/chrome/browser/browser_about_handler.h index 46ae100..e5e31c9f 100644 --- a/chrome/browser/browser_about_handler.h +++ b/chrome/browser/browser_about_handler.h @@ -28,7 +28,7 @@ bool WillHandleBrowserAboutURL(GURL* url, Profile* profile); // Register the data source for chrome://about URLs. // Safe to call multiple times. -void InitializeAboutDataSource(); +void InitializeAboutDataSource(Profile* profile); // We have a few magic commands that don't cause navigations, but rather pop up // dialogs. This function handles those cases, and returns true if so. In this |