diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 18:27:01 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 18:27:01 +0000 |
commit | c98c928aa38e31d44c7a792f0d12da84471639ff (patch) | |
tree | 1e1050d39385fbdb787f5ae15dd2a38a143c8ebd /chrome/browser/browser_about_handler.h | |
parent | bab01969064bdb23cbd403aa86ddc85659d7b74e (diff) | |
download | chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.zip chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.tar.gz chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.tar.bz2 |
Revert 79651 - Coverity: Pass parameters by reference.
Also remove an unused function that I found.
CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072,
8637,8718,8726
BUG=none
TEST=non
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6730046
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6773015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79705 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_about_handler.h')
-rw-r--r-- | chrome/browser/browser_about_handler.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/chrome/browser/browser_about_handler.h b/chrome/browser/browser_about_handler.h index d319fbe..b894ceb 100644 --- a/chrome/browser/browser_about_handler.h +++ b/chrome/browser/browser_about_handler.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -52,14 +52,14 @@ class AboutTcmallocOutputs { AboutTcmallocOutputsType* outputs() { return &outputs_; } // Records the output for a specified header string. - void SetOutput(const std::string& header, const std::string& output) { + void SetOutput(std::string header, std::string output) { outputs_[header] = output; } // Callback for output returned from renderer processes. Adds // the output for a canonical renderer header string that // incorporates the pid. - void RendererCallback(base::ProcessId pid, const std::string& output) { + void RendererCallback(base::ProcessId pid, std::string output) { SetOutput(StringPrintf("Renderer PID %d", static_cast<int>(pid)), output); } @@ -75,8 +75,7 @@ class AboutTcmallocOutputs { }; // Glue between the callback task and the method in the singleton. -void AboutTcmallocRendererCallback(base::ProcessId pid, - const std::string& output); +void AboutTcmallocRendererCallback(base::ProcessId pid, std::string output); #endif #endif // CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_ |