summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_accessibility_manager.h
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-04 03:15:58 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-04 03:15:58 +0000
commit39b7b06790a776ee2247f391b1b2e3af1a335503 (patch)
tree8813c8831c92e6f00e8e72bbeaa95693e695c683 /chrome/browser/browser_accessibility_manager.h
parentd718a62d075bdd6f45a128bd5d82358d73799300 (diff)
downloadchromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.zip
chromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.tar.gz
chromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.tar.bz2
Make it easier/less work/less error-prone to create new IPC channel types (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest
Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_accessibility_manager.h')
-rw-r--r--chrome/browser/browser_accessibility_manager.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/browser_accessibility_manager.h b/chrome/browser/browser_accessibility_manager.h
index c9c5ad5..dcda60c 100644
--- a/chrome/browser/browser_accessibility_manager.h
+++ b/chrome/browser/browser_accessibility_manager.h
@@ -15,6 +15,7 @@
class BrowserAccessibility;
class RenderProcessHost;
class RenderWidgetHost;
+struct ViewHostMsg_Accessibility_Out_Params;
////////////////////////////////////////////////////////////////////////////////
//
@@ -52,7 +53,7 @@ class BrowserAccessibilityManager : public NotificationObserver {
LONG input2);
// Wrapper function, for cleaner code.
- ViewHostMsg_Accessibility_Out_Params response();
+ const ViewHostMsg_Accessibility_Out_Params& response();
// Retrieves the parent HWND connected to the provided id.
HWND parent_hwnd(int id);