diff options
author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 16:49:16 +0000 |
---|---|---|
committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 16:49:16 +0000 |
commit | 1b74d2120db778a1809ddb5ca395e149d75e68f2 (patch) | |
tree | 35f7c3b6b8010316d6211e38793d5b4016315642 /chrome/browser/browser_browsertest.cc | |
parent | 7c44ec5eac469803e7531e7e604673e536d50753 (diff) | |
download | chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.zip chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.tar.gz chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.tar.bz2 |
chromium-os:7243: Fix so that extensions create popup windows of TYPE_APP_POPUP.
Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow
and call it from ExtensionHost::ShowCreatedWindow.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243
TEST=Test popup windows in general. See issue for specific test case.
Review URL: http://codereview.chromium.org/3532011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_browsertest.cc')
-rw-r--r-- | chrome/browser/browser_browsertest.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/browser_browsertest.cc b/chrome/browser/browser_browsertest.cc index ecf2692..5dab3bf 100644 --- a/chrome/browser/browser_browsertest.cc +++ b/chrome/browser/browser_browsertest.cc @@ -599,7 +599,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) { EXPECT_EQ(1, browser()->tab_count()); // Open a popup browser with a single blank foreground tab. - Browser* popup_browser = browser()->CreateForPopup(browser()->profile()); + Browser* popup_browser = browser()->CreateForType(Browser::TYPE_POPUP, + browser()->profile()); popup_browser->AddBlankTab(true); EXPECT_EQ(1, popup_browser->tab_count()); |