summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_focus_uitest.cc
diff options
context:
space:
mode:
authorben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-02 15:15:33 +0000
committerben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-02 15:15:33 +0000
commit616381f0a55322de447465573e39612e5af18b31 (patch)
tree4cbf687bb163f3dcd95e55e7be7fc9197e0dd8fd /chrome/browser/browser_focus_uitest.cc
parente5925962c61dbb9c8f5a5425ca2dc2953fb6a3e1 (diff)
downloadchromium_src-616381f0a55322de447465573e39612e5af18b31.zip
chromium_src-616381f0a55322de447465573e39612e5af18b31.tar.gz
chromium_src-616381f0a55322de447465573e39612e5af18b31.tar.bz2
Make all browser code use browser::Navigate to open tabs.
BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_focus_uitest.cc')
-rw-r--r--chrome/browser/browser_focus_uitest.cc11
1 files changed, 3 insertions, 8 deletions
diff --git a/chrome/browser/browser_focus_uitest.cc b/chrome/browser/browser_focus_uitest.cc
index 1099103..d9771db 100644
--- a/chrome/browser/browser_focus_uitest.cc
+++ b/chrome/browser/browser_focus_uitest.cc
@@ -217,11 +217,8 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, TabsRememberFocus) {
ui_test_utils::NavigateToURL(browser(), url);
// Create several tabs.
- for (int i = 0; i < 4; ++i) {
- Browser::AddTabWithURLParams params(url, PageTransition::TYPED);
- browser()->AddTabWithURL(&params);
- EXPECT_EQ(browser(), params.target);
- }
+ for (int i = 0; i < 4; ++i)
+ browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
// Alternate focus for the tab.
const bool kFocusPage[3][5] = {
@@ -296,9 +293,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, MAYBE_TabsRememberFocusFindInPage) {
browser()->FocusLocationBar();
// Create a 2nd tab.
- Browser::AddTabWithURLParams params(url, PageTransition::TYPED);
- browser()->AddTabWithURL(&params);
- EXPECT_EQ(browser(), params.target);
+ browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
// Focus should be on the recently opened tab page.
ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW));