diff options
author | mdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 22:54:00 +0000 |
---|---|---|
committer | mdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 22:54:00 +0000 |
commit | fe989f1881aad3beb18ed86b18f8cb19a11910ea (patch) | |
tree | d05decd90135a3a7c2f257ef5c9dfb3ff7306738 /chrome/browser/browser_init.cc | |
parent | cfe8a11e7670c898b60961bd6f8740be3e0d0244 (diff) | |
download | chromium_src-fe989f1881aad3beb18ed86b18f8cb19a11910ea.zip chromium_src-fe989f1881aad3beb18ed86b18f8cb19a11910ea.tar.gz chromium_src-fe989f1881aad3beb18ed86b18f8cb19a11910ea.tar.bz2 |
Be more paranoid when checking the default browser in Windows and return "not default" rather than "can't tell" in most cases.
Also undo previous fixes that worked around an incorrect return value; one of them (the infobar change) regresses the Linux version to display the infobar in cases where we would not be able to set ourselves as the default anyway (which was the original reason for the change that broke things on Windows).
BUG=28429, 27403
TEST=(windows) install chrome but don't set it as the default during install, then restart it and verify that the infobar shows and chrome can still be set as the default
TEST=(linux) run chrome in an unsupported desktop environment and verify that it neither displays the infobar asking to be made the default browser nor claims that it is the default browser in options
Review URL: http://codereview.chromium.org/434022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33147 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_init.cc')
-rw-r--r-- | chrome/browser/browser_init.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/browser/browser_init.cc b/chrome/browser/browser_init.cc index 6cb475f..847e966 100644 --- a/chrome/browser/browser_init.cc +++ b/chrome/browser/browser_init.cc @@ -180,10 +180,8 @@ class CheckDefaultBrowserTask : public Task { } virtual void Run() { - if (ShellIntegration::IsDefaultBrowser() == - ShellIntegration::IS_DEFAULT_BROWSER) { + if (ShellIntegration::IsDefaultBrowser()) return; - } ChromeThread::PostTask( ChromeThread::UI, FROM_HERE, new NotifyNotDefaultBrowserTask()); |