diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 08:03:53 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 08:03:53 +0000 |
| commit | a8fa243a05207629542fd74350aca146b840efda (patch) | |
| tree | e756ddc26e80e4bebfcac034368dc288fb0ff5f1 /chrome/browser/browser_keyevents_browsertest.cc | |
| parent | dabcea0aaac46ad9a598d70ed122bef365eed54f (diff) | |
| download | chromium_src-a8fa243a05207629542fd74350aca146b840efda.zip chromium_src-a8fa243a05207629542fd74350aca146b840efda.tar.gz chromium_src-a8fa243a05207629542fd74350aca146b840efda.tar.bz2 | |
Fix a crash at browser shutdown time.
Instead of stopping input processes from the destructor of InputMehotdLibrary,
we'll observe NotificationType::APP_EXITING to do it.
Here's the crash senario: When the browser shuts down,
1. AtExitManager deletes CrosLibrary, a singleton object.
2. CrosLibrary deletes InputMethodLibrary
3. InputMethodLibrary calls StopInputMethodProcesses().
4. StopInputMethodProcesses() relies on the CrosLibrary instance to alive.
5. Which is not the case here, so it crashes.
BUG=chromium-os:6995
TEST=confirmed that StopInputMethodProcesses() is called on APP_EXITINIG.
Review URL: http://codereview.chromium.org/3497006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60436 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_keyevents_browsertest.cc')
0 files changed, 0 insertions, 0 deletions