diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-12 17:44:44 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-12 17:44:44 +0000 |
commit | 1ea49d5727a9e6ba1375030c5e38b992ca4015e8 (patch) | |
tree | 0e6e49879c0ec583c6a3da445bfd0a1ba370e674 /chrome/browser/browser_keyevents_browsertest.cc | |
parent | a34f012a19f0915ba5ebc9ba8049763651839515 (diff) | |
download | chromium_src-1ea49d5727a9e6ba1375030c5e38b992ca4015e8.zip chromium_src-1ea49d5727a9e6ba1375030c5e38b992ca4015e8.tar.gz chromium_src-1ea49d5727a9e6ba1375030c5e38b992ca4015e8.tar.bz2 |
Renames TabStripModel and Browser's selected_index to
active_index. I plan on renaming more, but wanted to start with this
one.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6823064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81268 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_keyevents_browsertest.cc')
-rw-r--r-- | chrome/browser/browser_keyevents_browsertest.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/browser_keyevents_browsertest.cc b/chrome/browser/browser_keyevents_browsertest.cc index 90f8361..cc71af6 100644 --- a/chrome/browser/browser_keyevents_browsertest.cc +++ b/chrome/browser/browser_keyevents_browsertest.cc @@ -247,7 +247,7 @@ class BrowserKeyEventsTest : public InProcessBrowserTest { void TestKeyEvent(int tab_index, const KeyEventTestData& test) { ASSERT_LT(tab_index, browser()->tab_count()); - ASSERT_EQ(tab_index, browser()->selected_index()); + ASSERT_EQ(tab_index, browser()->active_index()); // Inform our testing web page that we are about to start testing a key // event. @@ -355,7 +355,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, NormalKeyEvents) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); for (size_t i = 0; i < arraysize(kTestNoInput); ++i) { EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestNoInput[i])) << "kTestNoInput[" << i << "] failed:\n" @@ -440,7 +440,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, CtrlKeyEvents) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); // Press Ctrl+F, which will make the Find box open and request focus. EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlF)); EXPECT_TRUE(IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)); @@ -485,7 +485,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, CommandKeyEvents) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); // Press Cmd+F, which will make the Find box open and request focus. EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCmdF)); EXPECT_TRUE(IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)); @@ -582,7 +582,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, AccessKeys) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); // Make sure no element is focused. EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L"")); // Alt+A should focus the element with accesskey = "A". @@ -677,7 +677,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_ReservedAccelerators) { EXPECT_EQ(1, result_length); EXPECT_EQ(2, browser()->tab_count()); - ASSERT_EQ(1, browser()->selected_index()); + ASSERT_EQ(1, browser()->active_index()); // Because of issue http://crbug.com/65375, switching back to the first tab // may cause the focus to be grabbed by omnibox. So instead, we load our @@ -747,7 +747,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"A")); ASSERT_NO_FATAL_FAILURE(SetTextBoxValue(tab_index, L"A", L"Hello")); // Move the caret to the beginning of the line. @@ -784,7 +784,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, PageUpDownKeys) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"A")); EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestPageUp)); EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestPageDown)); @@ -825,7 +825,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FocusMenuBarByAltKey) { ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER)); ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); - int tab_index = browser()->selected_index(); + int tab_index = browser()->active_index(); // Press and release Alt key to focus wrench menu button. EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAltKey)); EXPECT_TRUE(IsViewFocused(VIEW_ID_APP_MENU)); |