diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 00:51:49 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 00:51:49 +0000 |
| commit | f98b8f85a4c56c155019312da24d2a77c5ddc64a (patch) | |
| tree | 26d5dedf98f10e1389b8ea4677e65469ecbb3ebe /chrome/browser/browser_list.h | |
| parent | 3313382ec12352d9c7f2458cd293ed9f901aa38f (diff) | |
| download | chromium_src-f98b8f85a4c56c155019312da24d2a77c5ddc64a.zip chromium_src-f98b8f85a4c56c155019312da24d2a77c5ddc64a.tar.gz chromium_src-f98b8f85a4c56c155019312da24d2a77c5ddc64a.tar.bz2 | |
Fix --kiosk to work regardless of the startup pref setting or supplied URLs.
This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.
BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/2847090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54643 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_list.h')
| -rw-r--r-- | chrome/browser/browser_list.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/chrome/browser/browser_list.h b/chrome/browser/browser_list.h index 9e52aba..e709704 100644 --- a/chrome/browser/browser_list.h +++ b/chrome/browser/browser_list.h @@ -53,11 +53,8 @@ class BrowserList { // most recently open Browser's window was closed, returns the first Browser // in the list. If no Browsers exist, returns NULL. // - // WARNING: this is NULL until a browser becomes active. If during startup - // a browser does not become active (perhaps the user launches Chrome, then - // clicks on another app before the first browser window appears) then this - // returns NULL. - // WARNING #2: this will always be NULL in unit tests run on the bots. + // WARNING: This is NULL until a browser becomes active. That should happen + // during launch; see comment in BrowserInit::LaunchWithProfile::Launch(). static Browser* GetLastActive(); // Identical in behavior to GetLastActive(), except that the most recently |