diff options
author | dpolukhin@chromium.org <dpolukhin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-26 18:07:34 +0000 |
---|---|---|
committer | dpolukhin@chromium.org <dpolukhin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-26 18:07:34 +0000 |
commit | a37f1a7d7c5b1df7266613847c09dace68eb7c12 (patch) | |
tree | 7a298fc1d78b8c70406efcfc7c672c6b9ca7ab25 /chrome/browser/browser_main.cc | |
parent | a3ac4b4bd4572ff32c4d5f3e990bbd0e84491575 (diff) | |
download | chromium_src-a37f1a7d7c5b1df7266613847c09dace68eb7c12.zip chromium_src-a37f1a7d7c5b1df7266613847c09dace68eb7c12.tar.gz chromium_src-a37f1a7d7c5b1df7266613847c09dace68eb7c12.tar.bz2 |
Landing OEM customization CL for Denis
Original CL http://codereview.chromium.org/3026006
Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.
BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.
Review URL: http://codereview.chromium.org/3064002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53641 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_main.cc')
-rw-r--r-- | chrome/browser/browser_main.cc | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc index 7d645fe..746df9f 100644 --- a/chrome/browser/browser_main.cc +++ b/chrome/browser/browser_main.cc @@ -108,7 +108,6 @@ #include "app/win_util.h" #include "base/registry.h" #include "base/win_util.h" -#include "chrome/browser/browser.h" #include "chrome/browser/browser_trial.h" #include "chrome/browser/metrics/user_metrics.h" #include "chrome/browser/net/url_fixer_upper.h" @@ -645,42 +644,12 @@ void OptionallyRunChromeOSLoginManager(const CommandLine& parsed_command_line) { } } -bool OptionallyApplyServicesCustomizationFromCommandLine( - const CommandLine& parsed_command_line, - BrowserInit* browser_init) { - // For Chrome OS, we may need to fetch OEM partner's services customization - // manifest and apply the customizations. This happens on the very first run - // or if startup manifest is passed on the command line. - scoped_ptr<chromeos::ServicesCustomizationDocument> customization; - customization.reset(new chromeos::ServicesCustomizationDocument()); - bool manifest_loaded = false; - if (parsed_command_line.HasSwitch(switches::kServicesManifest)) { - // Load manifest from file specified by command line switch. - FilePath manifest_path = - parsed_command_line.GetSwitchValuePath(switches::kServicesManifest); - manifest_loaded = customization->LoadManifestFromFile(manifest_path); - DCHECK(manifest_loaded) << manifest_path.value(); - } - // If manifest was loaded successfully, apply the customizations. - if (manifest_loaded) { - browser_init->ApplyServicesCustomization(customization.get()); - } - return manifest_loaded; -} - #else void OptionallyRunChromeOSLoginManager(const CommandLine& parsed_command_line) { // Dummy empty function for non-ChromeOS builds to avoid extra ifdefs below. } -bool OptionallyApplyServicesCustomizationFromCommandLine( - const CommandLine& parsed_command_line, - BrowserInit* browser_init) { - // Dummy empty function for non-ChromeOS builds to avoid extra ifdefs below. - return false; -} - #endif // defined(OS_CHROMEOS) #if defined(OS_MACOSX) @@ -1127,12 +1096,6 @@ int BrowserMain(const MainFunctionParams& parameters) { RegisterExtensionProtocols(); RegisterMetadataURLRequestHandler(); - // If path to partner services customization document was passed on command - // line, apply the customizations (Chrome OS only). - // TODO(denisromanov): Remove this when not needed for testing. - OptionallyApplyServicesCustomizationFromCommandLine(parsed_command_line, - &browser_init); - // In unittest mode, this will do nothing. In normal mode, this will create // the global GoogleURLTracker and IntranetRedirectDetector instances, which // will promptly go to sleep for five and seven seconds, respectively (to |