diff options
author | jar@google.com <jar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-15 21:21:37 +0000 |
---|---|---|
committer | jar@google.com <jar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-15 21:21:37 +0000 |
commit | c631b6aabef4753d124fcda8fcd1ea3d6931803d (patch) | |
tree | 2d35566d0b4a6ea39c421c7b7bab9a42a1b6b15f /chrome/browser/browser_main.cc | |
parent | 9e82059e9496cd01dc4766197196c9d3330fa842 (diff) | |
download | chromium_src-c631b6aabef4753d124fcda8fcd1ea3d6931803d.zip chromium_src-c631b6aabef4753d124fcda8fcd1ea3d6931803d.tar.gz chromium_src-c631b6aabef4753d124fcda8fcd1ea3d6931803d.tar.bz2 |
Add a lot of robustness to SDCH filter decoding
a) Do meta-refresh (and partially disable sdch) when we have an sdch decode
error early on (due to lack of dictionary).
b) Gracefully handle proxy removal of "gzip" in "content-encoding: sdch,gzip".
c) Recover from completely stripped content encoding (in response to a
request for which we advertised an SDCH dictionary) by using a filter
that can optionally decode sdch with an optional gzip as well.
Some field tests have shown problems with this protocol's
transit across the ether. The general approach we've adopted
is to stop using SDCH on the problematic site when we have problems. This
will prevent a malicious site from shutting down all use of SDCH.
r=kmixter,openvcdiff,huanr
Review URL: http://codereview.chromium.org/6433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3420 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_main.cc')
-rw-r--r-- | chrome/browser/browser_main.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc index 1d8dda4..758d261 100644 --- a/chrome/browser/browser_main.cc +++ b/chrome/browser/browser_main.cc @@ -480,7 +480,7 @@ int BrowserMain(CommandLine &parsed_command_line, int show_command, sdch_manager.set_sdch_fetcher(new SdchDictionaryFetcher); std::wstring switch_domain = parsed_command_line.GetSwitchValue(switches::kSdchFilter); - sdch_manager.enable_sdch_support(WideToASCII(switch_domain)); + sdch_manager.EnableSdchSupport(WideToASCII(switch_domain)); } MetricsService* metrics = NULL; |