diff options
author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-15 00:18:30 +0000 |
---|---|---|
committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-15 00:18:30 +0000 |
commit | 9d84e1a1e1d17ab3d64757c0a82f7f95a0aae293 (patch) | |
tree | f70d6b45b28c268a03006d0859086d9649e4f0d2 /chrome/browser/browser_main_win.cc | |
parent | 12c0b1823a10d2b0cf63144bcd32b556c73177af (diff) | |
download | chromium_src-9d84e1a1e1d17ab3d64757c0a82f7f95a0aae293.zip chromium_src-9d84e1a1e1d17ab3d64757c0a82f7f95a0aae293.tar.gz chromium_src-9d84e1a1e1d17ab3d64757c0a82f7f95a0aae293.tar.bz2 |
Revert 66088 - Changing the installer switches from wchar_t[] to char[].
Because of this I'm also refactoring some code that before
was using wstring to build command lines by hand instead of
using the CommandLine class. Now we use CommandLine.
To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it.
TEST=There should be no changes in functionality. Run all installer tests.
BUG=61609
Review URL: http://codereview.chromium.org/4928002
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/4988001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66089 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_main_win.cc')
-rw-r--r-- | chrome/browser/browser_main_win.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/browser_main_win.cc b/chrome/browser/browser_main_win.cc index 7536a3b..65a991f 100644 --- a/chrome/browser/browser_main_win.cc +++ b/chrome/browser/browser_main_win.cc @@ -188,12 +188,12 @@ bool CheckMachineLevelInstall() { const std::wstring caption = l10n_util::GetString(IDS_PRODUCT_NAME); const UINT flags = MB_OK | MB_ICONERROR | MB_TOPMOST; win_util::MessageBox(NULL, text, caption, flags); - FilePath uninstall_path(InstallUtil::GetChromeUninstallCmd(false)); - CommandLine uninstall_cmd(uninstall_path); - if (!uninstall_cmd.GetProgram().value().empty()) { - uninstall_cmd.AppendSwitch(installer_util::switches::kForceUninstall); - uninstall_cmd.AppendSwitch( - installer_util::switches::kDoNotRemoveSharedItems); + std::wstring uninstall_cmd = InstallUtil::GetChromeUninstallCmd(false); + if (!uninstall_cmd.empty()) { + uninstall_cmd.append(L" --"); + uninstall_cmd.append(installer_util::switches::kForceUninstall); + uninstall_cmd.append(L" --"); + uninstall_cmd.append(installer_util::switches::kDoNotRemoveSharedItems); base::LaunchApp(uninstall_cmd, false, false, NULL); } return true; |