diff options
| author | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-03 01:19:49 +0000 |
|---|---|---|
| committer | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-03 01:19:49 +0000 |
| commit | db683c912eaf6b81ba64d49d4b3d796450609c90 (patch) | |
| tree | 1df96ee27e4cdf4ece4897ed9c59554fa0f854d9 /chrome/browser/browser_process_impl.h | |
| parent | febabf5b375a681dc96d239b5d6d218708ac2a37 (diff) | |
| download | chromium_src-db683c912eaf6b81ba64d49d4b3d796450609c90.zip chromium_src-db683c912eaf6b81ba64d49d4b3d796450609c90.tar.gz chromium_src-db683c912eaf6b81ba64d49d4b3d796450609c90.tar.bz2 | |
Reduce plugin_metrics_provider_ usage in MetricsService
This CL eliminates MetricsService's call to
PluginMetricsProvider::RecordPluginChanges (replaced by a new API on
MetricsProvider). It additionally adds a
MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer
call that API rather than calling MetricsService directly. This change will
enable easily moving MetricsService::LogPluginLoadingError() to
ChromeMetricsServiceClient once the latter is the class that keeps a weak
pointer to the plugin metrics provider.
BUG=375776
Review URL: https://codereview.chromium.org/308433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274403 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_process_impl.h')
| -rw-r--r-- | chrome/browser/browser_process_impl.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h index 5631a5e..932ca15 100644 --- a/chrome/browser/browser_process_impl.h +++ b/chrome/browser/browser_process_impl.h @@ -73,6 +73,7 @@ class BrowserProcessImpl : public BrowserProcess, // BrowserProcess implementation. virtual void ResourceDispatcherHostCreated() OVERRIDE; virtual void EndSession() OVERRIDE; + virtual MetricsServicesManager* GetMetricsServicesManager() OVERRIDE; virtual MetricsService* metrics_service() OVERRIDE; virtual rappor::RapporService* rappor_service() OVERRIDE; virtual IOThread* io_thread() OVERRIDE; @@ -152,8 +153,6 @@ class BrowserProcessImpl : public BrowserProcess, void CreateStatusTray(); void CreateBackgroundModeManager(); - MetricsServicesManager* GetMetricsServicesManager(); - void ApplyAllowCrossOriginAuthPromptPolicy(); void ApplyDefaultBrowserPolicy(); void ApplyMetricsReportingPolicy(); |