diff options
author | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-20 20:52:20 +0000 |
---|---|---|
committer | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-20 20:52:20 +0000 |
commit | c984d9f8b393418f26c8a3a90ceaff17f2d421af (patch) | |
tree | 1e6d691629226bee23228b87b435957a01587c82 /chrome/browser/browser_shutdown.cc | |
parent | a82ac135a3453615f7289b5fbacc512576858639 (diff) | |
download | chromium_src-c984d9f8b393418f26c8a3a90ceaff17f2d421af.zip chromium_src-c984d9f8b393418f26c8a3a90ceaff17f2d421af.tar.gz chromium_src-c984d9f8b393418f26c8a3a90ceaff17f2d421af.tar.bz2 |
Moved code that generates APP_TERMINATING notification into BrowserList so it can be used on all platforms. Updated observers (ExtensionProcessManager,
BackgroundContents) to listen for APP_TERMINATING instead of listening for
BROWSER_CLOSED on some platforms.
APP_TERMINATING is now sent just before the main message loop exits rather than just after, but no code depends on this timing.
Updated Mac code to always call BrowserList::CloseAllBrowsers() even if there
are no open browsers, to ensure that APP_TERMINATING is always fired.
Changed BackgroundContentsService to keep the browser process alive when there
are BackgroundContents running and updated the unit tests.
Renamed BrowserList::IsInPersistentMode() => WillShutdownWhenLastBrowserCloses() and AllBrowsersClosed() => AllBrowsersClosedAndAppExiting() to more precisely indicate their true functions.
Exposed BrowserProcess::ModuleRefCount() so BrowserList can determine when the application is going to exit so the right notifications/callbacks can be generated.
Updated background-auto-update-restart code to use new BrowserList APIs to determine whether the application is running "in the background".
Added code to cancel shutdown on all plaforms if the user selects cancel in an onbeforeunload dialog.
BUG=45275
TEST=RunInBackgroundTest (ui_test)
Review URL: http://codereview.chromium.org/2866034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53092 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_shutdown.cc')
-rw-r--r-- | chrome/browser/browser_shutdown.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/browser/browser_shutdown.cc b/chrome/browser/browser_shutdown.cc index dd541ef..7e5fded 100644 --- a/chrome/browser/browser_shutdown.cc +++ b/chrome/browser/browser_shutdown.cc @@ -43,10 +43,8 @@ using base::TimeDelta; namespace browser_shutdown { -#if defined(OS_MACOSX) // Whether the browser is trying to quit (e.g., Quit chosen from menu). bool g_trying_to_quit = false; -#endif // OS_MACOSX Time shutdown_started_; ShutdownType shutdown_type_ = NOT_VALID; @@ -262,7 +260,6 @@ void ReadLastShutdownInfo() { &ReadLastShutdownFile, type, num_procs, num_procs_slow)); } -#if defined(OS_MACOSX) void SetTryingToQuit(bool quitting) { g_trying_to_quit = quitting; } @@ -270,6 +267,5 @@ void SetTryingToQuit(bool quitting) { bool IsTryingToQuit() { return g_trying_to_quit; } -#endif } // namespace browser_shutdown |