diff options
| author | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-13 20:06:05 +0000 |
|---|---|---|
| committer | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-13 20:06:05 +0000 |
| commit | c6032e8b0dccde8dc24598e8c93d870b8513a42e (patch) | |
| tree | 97c064cf68644e68aa81ca2e7eeb73534871e593 /chrome/browser/browser_shutdown.h | |
| parent | ee9372cbbc0bbeb8c8f06473409f3749eb443dd2 (diff) | |
| download | chromium_src-c6032e8b0dccde8dc24598e8c93d870b8513a42e.zip chromium_src-c6032e8b0dccde8dc24598e8c93d870b8513a42e.tar.gz chromium_src-c6032e8b0dccde8dc24598e8c93d870b8513a42e.tar.bz2 | |
This is a second attempt of http://codereview.chromium.org/3175038
It failed the Vista Perf UI tests. This is because those tests close the browser upon an error. And they always get an error when the session is closed in the middle of the test.
The new changes are in chrome/browser/automation/testing_automation_provider.cc
BUG=50006
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)
use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3364019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_shutdown.h')
| -rw-r--r-- | chrome/browser/browser_shutdown.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/browser_shutdown.h b/chrome/browser/browser_shutdown.h index c2e38b5..0df2919 100644 --- a/chrome/browser/browser_shutdown.h +++ b/chrome/browser/browser_shutdown.h @@ -66,6 +66,11 @@ void SetTryingToQuit(bool quitting); // General accessor. bool IsTryingToQuit(); +// This is true on X during an END_SESSION, when we can no longer depend +// on the X server to be running. As a result we don't explicitly close the +// browser windows, which can lead to conditions which would fail checks. +bool ShuttingDownWithoutClosingBrowsers(); + } // namespace browser_shutdown #endif // CHROME_BROWSER_BROWSER_SHUTDOWN_H__ |