diff options
| author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 20:38:41 +0000 |
|---|---|---|
| committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 20:38:41 +0000 |
| commit | ab8089b5a8442d10b85fd12b40b8771c86c81b8d (patch) | |
| tree | 8bca61bea733d5b55d4bba88db02dd96f2f742ed /chrome/browser/browser_theme_pack.cc | |
| parent | 69bb5870fb38eb83ce767ed9b2434827a08f100d (diff) | |
| download | chromium_src-ab8089b5a8442d10b85fd12b40b8771c86c81b8d.zip chromium_src-ab8089b5a8442d10b85fd12b40b8771c86c81b8d.tar.gz chromium_src-ab8089b5a8442d10b85fd12b40b8771c86c81b8d.tar.bz2 | |
Speculative fix for the windows theme crasher.
I have no good ideas about this, so I'm moving the theme building to the
UI thread to remove the possibility of clobbering the memory of the
Task*. If THAT doesn't work, I've tried to get the theme name into the
stack trace and therefore the minidumps.
BUG=31719
TEST=none
Review URL: http://codereview.chromium.org/536024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36036 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_theme_pack.cc')
| -rw-r--r-- | chrome/browser/browser_theme_pack.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/browser_theme_pack.cc b/chrome/browser/browser_theme_pack.cc index acfa24e..b6e3fd9 100644 --- a/chrome/browser/browser_theme_pack.cc +++ b/chrome/browser/browser_theme_pack.cc @@ -291,7 +291,6 @@ scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromDataPack( } bool BrowserThemePack::WriteToDisk(FilePath path) const { - DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE)); // Add resources for each of the property arrays. RawDataForWriting resources; resources[kHeaderID] = base::StringPiece( @@ -819,7 +818,6 @@ void BrowserThemePack::GenerateTabBackgroundImages(ImageCache* bitmaps) const { void BrowserThemePack::RepackImages(const ImageCache& images, RawImages* reencoded_images) const { - DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE)); for (ImageCache::const_iterator it = images.begin(); it != images.end(); ++it) { std::vector<unsigned char> image_data; @@ -847,7 +845,6 @@ void BrowserThemePack::MergeImageCaches( void BrowserThemePack::AddRawImagesTo(const RawImages& images, RawDataForWriting* out) const { - DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE)); for (RawImages::const_iterator it = images.begin(); it != images.end(); ++it) { (*out)[it->first] = base::StringPiece( |