diff options
| author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 22:19:24 +0000 |
|---|---|---|
| committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 22:19:24 +0000 |
| commit | 00ed48fe2d42c952a3d41c83ed26a130342521aa (patch) | |
| tree | 80e7d1b3f210725306d505c21a989c963e902f0a /chrome/browser/browser_thread_unittest.cc | |
| parent | 8c7697346f2632d3356e9d57b8f105e9cfa26747 (diff) | |
| download | chromium_src-00ed48fe2d42c952a3d41c83ed26a130342521aa.zip chromium_src-00ed48fe2d42c952a3d41c83ed26a130342521aa.tar.gz chromium_src-00ed48fe2d42c952a3d41c83ed26a130342521aa.tar.bz2 | |
Revert "Revert "Const-ify RefCountedThreadSafe::AddRef and Release.""
chrome_frame failed to compile last time. I needed to add a "mutable" to a
member variable in chrome_frame/metrics_service.cc.
Review URL: http://codereview.chromium.org/3971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63574 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_thread_unittest.cc')
| -rw-r--r-- | chrome/browser/browser_thread_unittest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/browser_thread_unittest.cc b/chrome/browser/browser_thread_unittest.cc index d2c19d8..948709a 100644 --- a/chrome/browser/browser_thread_unittest.cc +++ b/chrome/browser/browser_thread_unittest.cc @@ -11,7 +11,7 @@ class BrowserThreadTest : public testing::Test { public: - void Release() { + void Release() const { CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask); } @@ -77,7 +77,9 @@ class BrowserThreadTest : public testing::Test { private: scoped_ptr<BrowserThread> ui_thread_; scoped_ptr<BrowserThread> file_thread_; - MessageLoop loop_; + // It's kind of ugly to make this mutable - solely so we can post the Quit + // Task from Release(). This should be fixed. + mutable MessageLoop loop_; }; TEST_F(BrowserThreadTest, PostTask) { |