diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 02:18:30 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 02:18:30 +0000 |
| commit | 8beff076f15f979f9334ad9f962444f57050fe52 (patch) | |
| tree | f504f4c35856204e385fa12e2f3c8a45c6bdc6a8 /chrome/browser/browser_uitest.cc | |
| parent | e67efe3af047fdf3ca4e62ed54cadf12b5bbbea2 (diff) | |
| download | chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.zip chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.tar.gz chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.tar.bz2 | |
Get rid of the need for cross process events in order to get plugin processes to run nested message loops when a dialog is shown. Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event. This fixes showModalDialog on Linux/Mac.
BUG=15891
TEST=covered by UI tests, undef's them for POSIX
Review URL: http://codereview.chromium.org/242043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27456 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_uitest.cc')
| -rw-r--r-- | chrome/browser/browser_uitest.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc index 1ef62a1..0a3fee9 100644 --- a/chrome/browser/browser_uitest.cc +++ b/chrome/browser/browser_uitest.cc @@ -191,7 +191,6 @@ TEST_F(VisibleBrowserTest, WindowOpenClose) { } #endif -#if defined(OS_WIN) // only works on Windows for now: http:://crbug.com/15891 class ShowModalDialogTest : public UITest { public: ShowModalDialogTest() { @@ -221,7 +220,6 @@ TEST_F(ShowModalDialogTest, BasicTest) { ASSERT_TRUE(tab->GetTabTitle(&title)); ASSERT_EQ(L"SUCCESS", title); } -#endif class SecurityTest : public UITest { protected: |