diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-10 22:28:58 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-10 22:28:58 +0000 |
| commit | 4b4d1adc53b7e016b7966a38c48a31ec9e0aeda2 (patch) | |
| tree | e4dbd1104b38920b387b0a94436a83ecfc7736e3 /chrome/browser/browser_uitest.cc | |
| parent | 0b847e38433afef0b207c85ae593d39501696aad (diff) | |
| download | chromium_src-4b4d1adc53b7e016b7966a38c48a31ec9e0aeda2.zip chromium_src-4b4d1adc53b7e016b7966a38c48a31ec9e0aeda2.tar.gz chromium_src-4b4d1adc53b7e016b7966a38c48a31ec9e0aeda2.tar.bz2 | |
Cleanup part 6.
Lots of small things (mostly in spellcheck code), e.g.:
* L"" -> std::wstring()
* type *var; -> type* var;
* Fix parameter line-wrapping to comply with style guide
* Remove unnecessary classname scoping inside class delcaration
* Remove empty declaration
* Add/remove blank lines in hopes of increasing readability
* Add block ("{", "}") around local use of a temporary that is later redefined
* Fold temps into other statements where obvious
* Use std::find() instead of hand-rolling the same functionality
* Combine distinct cases in switch statements when they all do the same thing
* Range-check to avoid some algorithmic work when it's not needed
* at() -> []
...and various others. Pretty much every change stands on its own. Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground. (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). )
Review URL: http://codereview.chromium.org/13688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_uitest.cc')
| -rw-r--r-- | chrome/browser/browser_uitest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc index d849860..740b2ea 100644 --- a/chrome/browser/browser_uitest.cc +++ b/chrome/browser/browser_uitest.cc @@ -256,7 +256,7 @@ TEST_F(BrowserTest, DuplicateTab) { ASSERT_TRUE(window_count == initial_window_count); tab_proxy.reset(browser_proxy->GetTab(1)); - + ASSERT_TRUE(tab_proxy != NULL); ASSERT_TRUE(tab_proxy->WaitForTabToBeRestored(kWaitForActionMsec)); // Verify the stack of urls. |