diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
commit | 8030f01f1f6e77e0ba72c591680a546da82f21f9 (patch) | |
tree | f643e742dcc2ccca5da232c1c7d6964b20a79090 /chrome/browser/browser_window.h | |
parent | cdacb88cb3d3b11f21caae229816a68cab3170b2 (diff) | |
download | chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.zip chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.gz chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.bz2 |
Makes it so that you shouldn't be able to get a big fat bookmark
bar. This happened because when we changed from needing a
bookmarkbar/extension-shelf to not needing one we processed the layout
change asynchronously, but could paint immediately and painting always
checks the current state. I initially made painting/layout stay in
sync with regards to whether they thought the bookmark bar should be
shown, which also fixes this, but because we process the change async
there was still some noticable jank. Instead I've changed processing
of the transition from needing bars to not (or vice-versa) to be
synchronous.
BUG=22165
TEST=see bug
Review URL: http://codereview.chromium.org/219034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_window.h')
-rw-r--r-- | chrome/browser/browser_window.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/browser_window.h b/chrome/browser/browser_window.h index cae21a5..5de0857 100644 --- a/chrome/browser/browser_window.h +++ b/chrome/browser/browser_window.h @@ -82,6 +82,14 @@ class BrowserWindow { // frames may need to refresh their title bar. virtual void UpdateTitleBar() = 0; + // Invoked when the visibility of the bookmark bar or extension shelf changes. + // NOTE: this is NOT sent when the user toggles the visibility of one of + // these shelves, but rather when the user transitions from a page that forces + // the shelves to be visibile to one that doesn't have them visible (or + // vice-versa). + // TODO(sky): see about routing visibility pref changing through here too. + virtual void ShelfVisibilityChanged() = 0; + // Inform the frame that the dev tools window for the selected tab has // changed. virtual void UpdateDevTools() = 0; |