diff options
| author | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-18 21:51:39 +0000 |
|---|---|---|
| committer | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-18 21:51:39 +0000 |
| commit | 41741a96ce6b7b3cfca3d59ef3bb59064dc939e0 (patch) | |
| tree | 04691674fee10a438145d1bc42325c9ea00d2f7a /chrome/browser/browser_window_cocoa.mm | |
| parent | 4daf03583a367047c06cbc05aace8f9edc355237 (diff) | |
| download | chromium_src-41741a96ce6b7b3cfca3d59ef3bb59064dc939e0.zip chromium_src-41741a96ce6b7b3cfca3d59ef3bb59064dc939e0.tar.gz chromium_src-41741a96ce6b7b3cfca3d59ef3bb59064dc939e0.tar.bz2 | |
Fix window close and application quit on Mac to call the proper Browser machinery in the proper order. Add comments to BrowserWindow::Close to stress its assumptions. DCHECK that nobody adds a NULL browser to the browser list.
Review URL: http://codereview.chromium.org/20460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9973 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_window_cocoa.mm')
| -rw-r--r-- | chrome/browser/browser_window_cocoa.mm | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/browser_window_cocoa.mm b/chrome/browser/browser_window_cocoa.mm index 0780734..bbf6735 100644 --- a/chrome/browser/browser_window_cocoa.mm +++ b/chrome/browser/browser_window_cocoa.mm @@ -31,6 +31,9 @@ void BrowserWindowCocoa::SetBounds(const gfx::Rect& bounds) { [screen frame].size.height - bounds.height() - bounds.y(); } +// Callers assume that this doesn't immediately delete the Browser object. +// The controller implementing the window delegate methods called from +// |-performClose:| must take precautiions to ensure that. void BrowserWindowCocoa::Close() { [window_ orderOut:controller_]; [window_ performClose:controller_]; @@ -97,6 +100,8 @@ bool BrowserWindowCocoa::IsFullscreen() const { } gfx::Rect BrowserWindowCocoa::GetRootWindowResizerRect() const { + // TODO(pinkerton): fill this in so scrollbars go in the correct places + NOTIMPLEMENTED(); return gfx::Rect(); } |