diff options
| author | dmaclach@chromium.org <dmaclach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-18 00:40:17 +0000 |
|---|---|---|
| committer | dmaclach@chromium.org <dmaclach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-18 00:40:17 +0000 |
| commit | 30c918084bac874b6cfaabb93f0bb2545c5354e2 (patch) | |
| tree | 45bd81ec93407433426c0a6d1421bc189a96c2c4 /chrome/browser/bug_report_util.cc | |
| parent | d9cb161850584e5d277b141aadb68abec0af28bb (diff) | |
| download | chromium_src-30c918084bac874b6cfaabb93f0bb2545c5354e2.zip chromium_src-30c918084bac874b6cfaabb93f0bb2545c5354e2.tar.gz chromium_src-30c918084bac874b6cfaabb93f0bb2545c5354e2.tar.bz2 | |
Revert 69592 - file_version_info was not finding Mac values correctly.
Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/5815001
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/6017003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bug_report_util.cc')
| -rw-r--r-- | chrome/browser/bug_report_util.cc | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/chrome/browser/bug_report_util.cc b/chrome/browser/bug_report_util.cc index b89d742..28cc685 100644 --- a/chrome/browser/bug_report_util.cc +++ b/chrome/browser/bug_report_util.cc @@ -309,11 +309,13 @@ void BugReportUtil::SendReport(Profile* profile, // Add the Chrome version chrome::VersionInfo version_info; - std::string chrome_version = version_info.Name() + " - " + - version_info.Version() + - " (" + version_info.LastChange() + ")"; - AddFeedbackData(&feedback_data, std::string(kChromeVersionTag), - chrome_version); + if (version_info.is_valid()) { + std::string chrome_version = version_info.Name() + " - " + + version_info.Version() + + " (" + version_info.LastChange() + ")"; + AddFeedbackData(&feedback_data, std::string(kChromeVersionTag), + chrome_version); + } // Add OS version (eg, for WinXP SP2: "5.1.2600 Service Pack 2"). std::string os_version = ""; |