diff options
| author | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-15 19:52:37 +0000 |
|---|---|---|
| committer | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-15 19:52:37 +0000 |
| commit | 27286e7a5905dcde71f834430b62235a40a2d020 (patch) | |
| tree | e8153a6374f0dc66d369bf9be1eb83b164948f59 /chrome/browser/cancelable_request.cc | |
| parent | 7d505dd8c384bafe4412c9625c358347bfc5770a (diff) | |
| download | chromium_src-27286e7a5905dcde71f834430b62235a40a2d020.zip chromium_src-27286e7a5905dcde71f834430b62235a40a2d020.tar.gz chromium_src-27286e7a5905dcde71f834430b62235a40a2d020.tar.bz2 | |
mac: totally revamp "Aw Snap" page, implement new "Learn more" link, add unittests.
- totally revamp "Aw Snap" page to use xib resource, to reduce initialization code
- new SadTabController:
- controls SadTabView, via xib
- uses TabContents in init, so as to launch url for link; used to use BrowserList::GetLastActive but that's null in chrome-frame release
- if TabContents is nil, remove link in view
- encapsulates the setting up and removing of its SadTabView within and shield them from TabContentsView, which only access the controller
- SadTabView repositions and resizes subviews when browser window is resized, including (un)wrapping of message.
- action for link is decoupled from target to facilitate unittesting
- new SadTabControllerTest that tests initing controller with and without TabContents, and clicking on link
BUG=27212
TEST=Verify that "Aw Snap" page shows up correctly, with the new "Learn more" link centered beneath the message. Contents should be centered in window when the latter resizes. If necessary, message should be wrapped, or unwrapped if previously wrapped and new width can accommodate.
Review URL: http://codereview.chromium.org/432015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34585 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cancelable_request.cc')
0 files changed, 0 insertions, 0 deletions