diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-11 19:35:02 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-11 19:35:02 +0000 |
commit | e04488797a798ff831d7d0b01e8374d714e56794 (patch) | |
tree | 0b341832c14b9676d35015f0ab92a6c426ed678e /chrome/browser/captive_portal | |
parent | 1d44c10678bbdf2dedaf5255f50b2881957a2604 (diff) | |
download | chromium_src-e04488797a798ff831d7d0b01e8374d714e56794.zip chromium_src-e04488797a798ff831d7d0b01e8374d714e56794.tar.gz chromium_src-e04488797a798ff831d7d0b01e8374d714e56794.tar.bz2 |
Remove TabStripModel wrapper use.
BUG=167548
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/11833044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176415 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/captive_portal')
-rw-r--r-- | chrome/browser/captive_portal/captive_portal_browsertest.cc | 12 | ||||
-rw-r--r-- | chrome/browser/captive_portal/captive_portal_tab_helper.cc | 4 |
2 files changed, 9 insertions, 7 deletions
diff --git a/chrome/browser/captive_portal/captive_portal_browsertest.cc b/chrome/browser/captive_portal/captive_portal_browsertest.cc index 255851e..6fb3ef2 100644 --- a/chrome/browser/captive_portal/captive_portal_browsertest.cc +++ b/chrome/browser/captive_portal/captive_portal_browsertest.cc @@ -1052,7 +1052,7 @@ void CaptivePortalBrowserTest::NavigateToPageExpectNoTest( // should be no new tabs. EXPECT_EQ(0, portal_observer.num_results_received()); EXPECT_FALSE(CheckPending(browser)); - EXPECT_EQ(1, browser->tab_count()); + EXPECT_EQ(1, browser->tab_strip_model()->count()); EXPECT_EQ(expected_navigations, navigation_observer.num_navigations()); EXPECT_EQ(0, NumLoadingTabs()); EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, @@ -1075,7 +1075,7 @@ void CaptivePortalBrowserTest::SlowLoadNoCaptivePortal( portal_observer.WaitForResults(1); - ASSERT_EQ(1, browser->tab_count()); + ASSERT_EQ(1, browser->tab_strip_model()->count()); EXPECT_EQ(expected_result, portal_observer.captive_portal_result()); EXPECT_EQ(1, portal_observer.num_results_received()); EXPECT_EQ(0, navigation_observer.num_navigations()); @@ -1089,7 +1089,7 @@ void CaptivePortalBrowserTest::SlowLoadNoCaptivePortal( URLRequestTimeoutOnDemandJob::FailJobs(1); navigation_observer.WaitForNavigations(1); - ASSERT_EQ(1, browser->tab_count()); + ASSERT_EQ(1, browser->tab_strip_model()->count()); EXPECT_EQ(1, portal_observer.num_results_received()); EXPECT_FALSE(CheckPending(browser)); EXPECT_EQ(0, NumLoadingTabs()); @@ -1113,8 +1113,8 @@ void CaptivePortalBrowserTest::FastTimeoutNoCaptivePortal( CaptivePortalObserver portal_observer(browser->profile()); // Neither of these should be changed by the navigation. - int active_index = browser->active_index(); - int expected_tab_count = browser->tab_count(); + int active_index = browser->tab_strip_model()->active_index(); + int expected_tab_count = browser->tab_strip_model()->count(); ui_test_utils::NavigateToURL( browser, @@ -1144,7 +1144,7 @@ void CaptivePortalBrowserTest::FastTimeoutNoCaptivePortal( EXPECT_FALSE(CheckPending(browser)); // Make sure no login tab was opened. - EXPECT_EQ(expected_tab_count, browser->tab_count()); + EXPECT_EQ(expected_tab_count, browser->tab_strip_model()->count()); } void CaptivePortalBrowserTest::SlowLoadBehindCaptivePortal( diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.cc b/chrome/browser/captive_portal/captive_portal_tab_helper.cc index f2e9490..a735f8e 100644 --- a/chrome/browser/captive_portal/captive_portal_tab_helper.cc +++ b/chrome/browser/captive_portal/captive_portal_tab_helper.cc @@ -12,6 +12,7 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_notification_types.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_service.h" @@ -251,7 +252,8 @@ void CaptivePortalTabHelper::OpenLoginTab() { // TODO(mmenke): Consider focusing that tab, at least if this is the tab // helper for the currently active tab for the profile. for (int i = 0; i < browser->tab_count(); ++i) { - content::WebContents* web_contents = chrome::GetWebContentsAt(browser, i); + content::WebContents* web_contents = + browser->tab_strip_model()->GetWebContentsAt(i); captive_portal::CaptivePortalTabHelper* captive_portal_tab_helper = captive_portal::CaptivePortalTabHelper::FromWebContents(web_contents); if (captive_portal_tab_helper->IsLoginTab()) |