summaryrefslogtreecommitdiffstats
path: root/chrome/browser/child_process_launcher.cc
diff options
context:
space:
mode:
authoreroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-16 00:07:48 +0000
committereroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-16 00:07:48 +0000
commit49836d5c8eed2ca1e857e72d9f6fd011ce2c51dd (patch)
tree038ef8f4be275b109ec9503c578acbaf3a97428e /chrome/browser/child_process_launcher.cc
parentd0c23038e59e9d9336cc81080f574e79eb8984d3 (diff)
downloadchromium_src-49836d5c8eed2ca1e857e72d9f6fd011ce2c51dd.zip
chromium_src-49836d5c8eed2ca1e857e72d9f6fd011ce2c51dd.tar.gz
chromium_src-49836d5c8eed2ca1e857e72d9f6fd011ce2c51dd.tar.bz2
Revert 43821 - Add some temporary instrumentation to help track down a crasher.
BUG=40447 TBR=huanr Review URL: http://codereview.chromium.org/1585019 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/1602026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44719 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/child_process_launcher.cc')
-rw-r--r--chrome/browser/child_process_launcher.cc31
1 files changed, 0 insertions, 31 deletions
diff --git a/chrome/browser/child_process_launcher.cc b/chrome/browser/child_process_launcher.cc
index 534368b..206d8a7 100644
--- a/chrome/browser/child_process_launcher.cc
+++ b/chrome/browser/child_process_launcher.cc
@@ -31,32 +31,6 @@
#include "base/global_descriptors_posix.h"
#endif
-// TODO(eroman): Debugging helper to make strings show up in mini-dumps.
-// Remove after done investigating 40447.
-class StackString {
- public:
- explicit StackString(const std::wstring& str) {
- length_ = str.size();
- memcpy(&buffer_[0], str.data(),
- std::min(sizeof(wchar_t) * str.length(),
- sizeof(buffer_)));
- }
-
- std::wstring ToString() {
- return std::wstring(buffer_, length_);
- }
-
- ~StackString() {
- // Hack to make sure compiler doesn't optimize us away.
- if (ToString() != ToString())
- LOG(INFO) << ToString();
- }
-
- private:
- wchar_t buffer_[128];
- size_t length_;
-};
-
// Having the functionality of ChildProcessLauncher be in an internal
// ref counted object allows us to automatically terminate the process when the
// parent class destructs, while still holding on to state that we need.
@@ -127,11 +101,6 @@ class ChildProcessLauncher::Context
scoped_ptr<CommandLine> cmd_line_deleter(cmd_line);
base::ProcessHandle handle = base::kNullProcessHandle;
#if defined(OS_WIN)
- // TODO(eroman): Remove after done investigating 40447.
- StackString stack_command_line(cmd_line->command_line_string());
- // This line might crash, since it calls the string copy-constructor:
- StackString stack_program(cmd_line->program());
-
handle = sandbox::StartProcessWithAccess(cmd_line, exposed_dir);
#elif defined(OS_POSIX)