Add more logging to pin down Mac GPU bots random crashes at browser startup.

It seems the crash comes from StartupBrowserCreator::ProcessCmdLineImpl().

Also revert the temporary logs that's no longer needed.

BUG=424024
TEST=
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/690263006

Cr-Commit-Position: refs/heads/master@{#302832}

1 files changed, 0 insertions, 12 deletions

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index c283f97..48e78ea 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1099,7 +1099,6 @@ void ChromeBrowserMainParts::PostBrowserStart() {
 
 int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreMainMessageLoopRunImpl");
-  VLOG(2) << "PreMainMessageLoopRunImpl : BEGIN";
   // Android updates the metrics service dynamically depending on whether the
   // application is in the foreground or not. Do not start here.
 #if !defined(OS_ANDROID)
@@ -1308,7 +1307,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
 
   // TODO(stevenjb): Move WIN and MACOSX specific code to appropriate Parts.
   // (requires supporting early exit).
-  VLOG(2) << "PreMainMessageLoopRunImpl : PostProfileInit";
   PostProfileInit();
 
   // Retrieve cached GL strings from local state and use them for GPU
@@ -1428,7 +1426,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   }
 #endif
 
-  VLOG(2) << "PreMainMessageLoopRunImpl : HandleTestParameters";
   HandleTestParameters(parsed_command_line());
   browser_process_->metrics_service()->RecordBreakpadHasDebugger(
       base::debug::BeingDebugged());
@@ -1484,7 +1481,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   // Make sure initial prefs are recorded
   PrefMetricsService::Factory::GetForProfile(profile_);
 
-  VLOG(2) << "PreMainMessageLoopRunImpl : PreBrowserStart";
   PreBrowserStart();
 
   // Instantiate the notification UI manager, as this triggers a perf timer
@@ -1524,7 +1520,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
       g_browser_process->profile_manager()->GetLastOpenedProfiles();
 #endif
 
-  VLOG(2) << "PreMainMessageLoopRunImpl : browser_creator_->Start";
   if (browser_creator_->Start(parsed_command_line(), base::FilePath(),
                               profile_, last_opened_profiles, &result_code)) {
 #if defined(OS_WIN) || (defined(OS_LINUX) && !defined(OS_CHROMEOS))
@@ -1543,7 +1538,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
     upgrade_util::SaveLastModifiedTimeOfExe();
 #endif
 
-    VLOG(2) << "PreMainMessageLoopRunImpl : SetLastRunTime";
     // Record now as the last successful chrome start.
     GoogleUpdateSettings::SetLastRunTime();
 
@@ -1580,14 +1574,12 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   } else {
     run_message_loop_ = false;
   }
-  VLOG(2) << "PreMainMessageLoopRunImpl : browser_creator_.reset()";
   browser_creator_.reset();
 
   process_power_collector_.reset(new ProcessPowerCollector);
   process_power_collector_->Initialize();
 #endif  // !defined(OS_ANDROID)
 
-  VLOG(2) << "PreMainMessageLoopRunImpl : PostBrowserStart";
   PostBrowserStart();
 
   if (parameters().ui_task) {
@@ -1603,13 +1595,11 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
     RecordBrowserStartupTime();
   }
 #endif
-  VLOG(2) << "PreMainMessageLoopRunImpl : END";
   return result_code_;
 }
 
 bool ChromeBrowserMainParts::MainMessageLoopRun(int* result_code) {
   TRACE_EVENT0("startup", "ChromeBrowserMainParts::MainMessageLoopRun");
-  VLOG(2) << "MainMessageLoopRun : BEGIN";
 #if defined(OS_ANDROID)
   // Chrome on Android does not use default MessageLoop. It has its own
   // Android specific MessageLoop
@@ -1626,7 +1616,6 @@ bool ChromeBrowserMainParts::MainMessageLoopRun(int* result_code) {
   // across versions.
   RecordBrowserStartupTime();
 
-  VLOG(2) << "MainMessageLoopRun : RunLoop";
   DCHECK(base::MessageLoopForUI::IsCurrent());
   base::RunLoop run_loop;
 
@@ -1637,7 +1626,6 @@ bool ChromeBrowserMainParts::MainMessageLoopRun(int* result_code) {
       g_browser_process->local_state());
   run_loop.Run();
 
-  VLOG(2) << "MainMessageLoopRun : END";
   return true;
 #endif
 }