diff options
author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-26 18:03:30 +0000 |
---|---|---|
committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-26 18:03:30 +0000 |
commit | b48c918f8397747d9a157a87a5cfc63eeed74710 (patch) | |
tree | 20bf06e2bb203915d5e135498538550d6b891e4f /chrome/browser/chrome_browser_parts_aura.cc | |
parent | 45952868429c278087b68d0e0e96f33ec70388fa (diff) | |
download | chromium_src-b48c918f8397747d9a157a87a5cfc63eeed74710.zip chromium_src-b48c918f8397747d9a157a87a5cfc63eeed74710.tar.gz chromium_src-b48c918f8397747d9a157a87a5cfc63eeed74710.tar.bz2 |
Make GTK and Aura parts orthogonal to OS parts
This CL moves GTK and Aura "Parts" out of the primary BrowserMainParts tree and into orthogonal parts that can be added independently. This was done in a way that will facilitate adding additional parts if (when) we need them.
The motivation for this was to
a) eliminate the existing typedef in chrome_browser_main_chromeos.h
b) reduce the number of #ifdefs required in the setup / parts code
For an outline of the new parts see:
https://docs.google.com/drawings/d/1-gIMl-81c4SvcMrT1xaxnDGibDe7VQfMkFT1bMnIvrg/edit?hl=en_US
Please consider this a proposal; I am entirely open to feedback.
BUG=none
TEST=Chrome compiles and passes tests on all platfroms.
Review URL: http://codereview.chromium.org/8302016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107383 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chrome_browser_parts_aura.cc')
-rw-r--r-- | chrome/browser/chrome_browser_parts_aura.cc | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/chrome/browser/chrome_browser_parts_aura.cc b/chrome/browser/chrome_browser_parts_aura.cc new file mode 100644 index 0000000..5ebe45f --- /dev/null +++ b/chrome/browser/chrome_browser_parts_aura.cc @@ -0,0 +1,28 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "chrome/browser/chrome_browser_parts_aura.h" + +#include "base/logging.h" + +ChromeBrowserPartsAura::ChromeBrowserPartsAura() + : content::BrowserMainParts() { +} + +void ChromeBrowserPartsAura::PreEarlyInitialization() { + NOTIMPLEMENTED(); +} + +bool ChromeBrowserPartsAura::MainMessageLoopRun(int* result_code) { + return false; +} + +void ChromeBrowserPartsAura::PostMainMessageLoopStart() { + NOTIMPLEMENTED(); +} + +void ChromeBrowserPartsAura::ShowMessageBox(const char* message) { + LOG(ERROR) << "ShowMessageBox (not implemented): " << message; + NOTIMPLEMENTED(); +} |