diff options
author | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 22:05:33 +0000 |
---|---|---|
committer | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 22:05:33 +0000 |
commit | 55474b575e7e36bea6e7ce2ed18b34ff98a654dc (patch) | |
tree | 5e71656e0795f2372268a5d645d904d0a884e024 /chrome/browser/chrome_thread.h | |
parent | 0d219e8c64fd474737eb88737a8af3221893393a (diff) | |
download | chromium_src-55474b575e7e36bea6e7ce2ed18b34ff98a654dc.zip chromium_src-55474b575e7e36bea6e7ce2ed18b34ff98a654dc.tar.gz chromium_src-55474b575e7e36bea6e7ce2ed18b34ff98a654dc.tar.bz2 |
Give each HistoryService instance it's own backend thread.
I had originally planned to push history_thread up to BrowserProcess,
but was scared away by the comment in ~Profile that talks about HistoryService
calling back into the bookmark bar model, and that it depended on join()ing at
that particular time to ensure this doesn't happen after the bookmark bar model has been reset.
I didn't use scoped_ptr for the thread because it makes the little dance
in CleanUp awkward.
TEST=any existing test that exersizes the history service. I added a ProfileManager
test that would fail without this change.
Review URL: http://codereview.chromium.org/73012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13703 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chrome_thread.h')
-rw-r--r-- | chrome/browser/chrome_thread.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/chrome_thread.h b/chrome/browser/chrome_thread.h index 53fa50b..6570f92 100644 --- a/chrome/browser/chrome_thread.h +++ b/chrome/browser/chrome_thread.h @@ -38,9 +38,6 @@ class ChromeThread : public base::Thread { // This is the thread that interacts with the database. DB, - // This is the thread that interacts with the history database. - HISTORY, - // This identifier does not represent a thread. Instead it counts the // number of well-known threads. Insert new well-known threads before this // identifier. @@ -72,7 +69,7 @@ class ChromeThread : public base::Thread { // An array of the ChromeThread objects. This array is protected by |lock_|. // The threads are not owned by this array. Typically, the threads are owned - // on the IU thread by the g_browser_process object. ChromeThreads remove + // on the UI thread by the g_browser_process object. ChromeThreads remove // themselves from this array upon destruction. static ChromeThread* chrome_threads_[ID_COUNT]; }; |