diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-17 05:10:30 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-17 05:10:30 +0000 |
| commit | 83aa77e873d1dfde716c0083f6f5704999c93748 (patch) | |
| tree | 0523199cb0032c5b48e2ca82aa243d1b65ce1fc9 /chrome/browser/chromeos/cros/cros_library.cc | |
| parent | af3b0898b4adf7961c5af8c6e1ef4909672c8488 (diff) | |
| download | chromium_src-83aa77e873d1dfde716c0083f6f5704999c93748.zip chromium_src-83aa77e873d1dfde716c0083f6f5704999c93748.tar.gz chromium_src-83aa77e873d1dfde716c0083f6f5704999c93748.tar.bz2 | |
Rework LibcrosService using our D-Bus library.
Also introduce DBusThreadManager, that manages the D-Bus thread, and
D-Bus clients using the thread.
cros_dbus_service.cc and proxy_resolution_service_provider.cc are based on
libcros_service_library.cc. The basic logic
is kept as before. The major changes are:
- Get rid of all libcros function calls (ex. StartLibCrosService).
- Export "ResolveProxy" D-Bus method from Chrome, instead of libcros.
- CrosDBusService is now managed by DBusThreadManager, instead of CrosLibrary.
- Reduce use of nested class per the C++ style guide.
- Now unit tested: libcros_service_unittest.cc
BUG=chromium-os:18904
TEST=on the device, change the proxy config to use http://proxyconfig.corp.google.com/wpad.dat, run /opt/google/chrome/chromeos/libcros_service_tester (installed by USE=install_tests gmerge libcros), and confirm the libcros service works as before.
Review URL: http://codereview.chromium.org/7819012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101640 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/cros/cros_library.cc')
| -rw-r--r-- | chrome/browser/chromeos/cros/cros_library.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/chromeos/cros/cros_library.cc b/chrome/browser/chromeos/cros/cros_library.cc index e3dc355..a3a748d 100644 --- a/chrome/browser/chromeos/cros/cros_library.cc +++ b/chrome/browser/chromeos/cros/cros_library.cc @@ -8,7 +8,6 @@ #include "chrome/browser/chromeos/cros/burn_library.h" #include "chrome/browser/chromeos/cros/cert_library.h" #include "chrome/browser/chromeos/cros/cryptohome_library.h" -#include "chrome/browser/chromeos/cros/libcros_service_library.h" #include "chrome/browser/chromeos/cros/library_loader.h" #include "chrome/browser/chromeos/cros/login_library.h" #include "chrome/browser/chromeos/cros/mount_library.h" @@ -82,7 +81,6 @@ DEFINE_GET_LIBRARY_METHOD(Brightness, brightness); DEFINE_GET_LIBRARY_METHOD(Burn, burn); DEFINE_GET_LIBRARY_METHOD(Cert, cert); DEFINE_GET_LIBRARY_METHOD(Cryptohome, crypto); -DEFINE_GET_LIBRARY_METHOD(LibCrosService, libcros_service); DEFINE_GET_LIBRARY_METHOD(Login, login); DEFINE_GET_LIBRARY_METHOD(Mount, mount); DEFINE_GET_LIBRARY_METHOD(Network, network); @@ -132,7 +130,6 @@ DEFINE_SET_LIBRARY_METHOD(Brightness, brightness); DEFINE_SET_LIBRARY_METHOD(Cert, cert); DEFINE_SET_LIBRARY_METHOD(Burn, burn); DEFINE_SET_LIBRARY_METHOD(Cryptohome, crypto); -DEFINE_SET_LIBRARY_METHOD(LibCrosService, libcros_service); DEFINE_SET_LIBRARY_METHOD(Login, login); DEFINE_SET_LIBRARY_METHOD(Mount, mount); DEFINE_SET_LIBRARY_METHOD(Network, network); |