summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/frame
diff options
context:
space:
mode:
authoroshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-05 21:19:26 +0000
committeroshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-05 21:19:26 +0000
commit0089e561bbbacde67df51ee7c9a6e3cf6c3cbfcf (patch)
tree1876d790c0b9c461ea369708c7d9e7943f2855db /chrome/browser/chromeos/frame
parentf9fd6bf3ad3b321743c91dbff12acb67a789fbe7 (diff)
downloadchromium_src-0089e561bbbacde67df51ee7c9a6e3cf6c3cbfcf.zip
chromium_src-0089e561bbbacde67df51ee7c9a6e3cf6c3cbfcf.tar.gz
chromium_src-0089e561bbbacde67df51ee7c9a6e3cf6c3cbfcf.tar.bz2
Lazy AppLauncher creation to make tests stable.
There seems to be a timing issue in renderer deletion and io thread deletion, and the resource that has to be deleted before io thread are not deleted by the time io thread is deleted. Since this will soon be changed, i just chagned this to be created on demand for now. This also reverts commit dd6c4ab11002a308bf8eede36bb632e95d3a1382. TBR=sky@chromium.org BUG=32641 TEST=none Review URL: http://codereview.chromium.org/669196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40780 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/frame')
-rw-r--r--chrome/browser/chromeos/frame/browser_view.cc4
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/chromeos/frame/browser_view.cc b/chrome/browser/chromeos/frame/browser_view.cc
index 032cf2d..ca90857 100644
--- a/chrome/browser/chromeos/frame/browser_view.cc
+++ b/chrome/browser/chromeos/frame/browser_view.cc
@@ -388,7 +388,6 @@ void BrowserView::Init() {
AddChildView(spacer_);
InitSystemMenu();
- main_menu_.reset(new AppLauncher());
// The ContextMenuController has to be set to a NonClientView but
// not to a NonClientFrameView because a TabStrip is not a child of
@@ -459,6 +458,9 @@ void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {
// views::ButtonListener overrides.
void BrowserView::ButtonPressed(views::Button* sender,
const views::Event& event) {
+ if (!main_menu_.get()) {
+ main_menu_.reset(new AppLauncher());
+ }
main_menu_->Show(browser());
}