diff options
| author | yusukes@google.com <yusukes@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-12 13:00:15 +0000 |
|---|---|---|
| committer | yusukes@google.com <yusukes@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-12 13:00:15 +0000 |
| commit | d01bb807aad3a4c2095954dc0cc3342a41323e46 (patch) | |
| tree | f9424bcf5098d9f290cfd123979b06a691571698 /chrome/browser/chromeos/preferences.h | |
| parent | ca449f177da1a0592b05f1f69249ebdc0342c6b6 (diff) | |
| download | chromium_src-d01bb807aad3a4c2095954dc0cc3342a41323e46.zip chromium_src-d01bb807aad3a4c2095954dc0cc3342a41323e46.tar.gz chromium_src-d01bb807aad3a4c2095954dc0cc3342a41323e46.tar.bz2 | |
Simplify Preferences::SetPreloadEngines() function.
Stop using SetInputMethodActivated cros API and use the generic API, SetImeConfig, instead. This fix greatly reduces total number of ibus_config_set_value() calls.
I'm still not 100% certain, but this change might fix crosbug.com/2471, "Fails to activate an input method occasionally." ibus-daemon seems to ignore too frequent ibus_config_set_value("general", "preload_engines", ...) calls.
BUG=crosbug.com/2471
TEST=see the bug
Review URL: http://codereview.chromium.org/1596021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44241 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/preferences.h')
| -rw-r--r-- | chrome/browser/chromeos/preferences.h | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/chrome/browser/chromeos/preferences.h b/chrome/browser/chromeos/preferences.h index 42a0090..04cf176 100644 --- a/chrome/browser/chromeos/preferences.h +++ b/chrome/browser/chromeos/preferences.h @@ -62,16 +62,11 @@ class Preferences : public NotificationObserver { const char* name, const std::vector<std::wstring>& values); - // Set input method hot-keys specified by |name| to |value|. - // Examples of |name|: "trigger", "next_engine" - // Examples of |value|: "" (no hot-keys), "Control+space,Hiragana" - void SetHotkeys(const char* name, const std::wstring& value); - - // Activates IMEs that are on |value|, which is a comma separated list of IME - // IDs (e.g. "xkb:en,pinyin,hangul,m17n:ar:kbd"), and deactivates all other - // IMEs that are currently active. |value| could be empty. In that case, this - // function deactivates all active IMEs. - void SetPreloadEngines(const std::wstring& value); + // A variant of SetLanguageConfigStringList. You can pass comma-separated + // values. Examples of |value|: "", "Control+space,Hiragana" + void SetLanguageConfigStringListAsCSV(const char* section, + const char* name, + const std::wstring& value); StringPrefMember timezone_; BooleanPrefMember tap_to_click_enabled_; |