diff options
author | kochi@chromium.org <kochi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 08:43:52 +0000 |
---|---|---|
committer | kochi@chromium.org <kochi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 08:43:52 +0000 |
commit | 54023fa1158bb0384391950d224817c170503267 (patch) | |
tree | 1f3f02fb6e1dce1984be8ee64e0daace31c5fda7 /chrome/browser/chromeos | |
parent | f773e4217d06e704ae473beb0fd9a94f1f2bc4d9 (diff) | |
download | chromium_src-54023fa1158bb0384391950d224817c170503267.zip chromium_src-54023fa1158bb0384391950d224817c170503267.tar.gz chromium_src-54023fa1158bb0384391950d224817c170503267.tar.bz2 |
Don't use anonymous namespace in header files.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces
BUG=none
TEST=compile and run manually
Review URL: http://codereview.chromium.org/3293014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58799 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos')
-rw-r--r-- | chrome/browser/chromeos/dom_ui/language_options_util.cc | 18 | ||||
-rw-r--r-- | chrome/browser/chromeos/dom_ui/language_options_util.h | 16 |
2 files changed, 21 insertions, 13 deletions
diff --git a/chrome/browser/chromeos/dom_ui/language_options_util.cc b/chrome/browser/chromeos/dom_ui/language_options_util.cc new file mode 100644 index 0000000..42d7d21 --- /dev/null +++ b/chrome/browser/chromeos/dom_ui/language_options_util.cc @@ -0,0 +1,18 @@ +// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "chrome/browser/chromeos/dom_ui/language_options_util.h" + +namespace chromeos { + +// See comments in .h. +Value* CreateValue(const char* in_value) { + return Value::CreateStringValue(in_value); +} + +Value* CreateValue(int in_value) { + return Value::CreateIntegerValue(in_value); +} + +} // namespace chromeos diff --git a/chrome/browser/chromeos/dom_ui/language_options_util.h b/chrome/browser/chromeos/dom_ui/language_options_util.h index 5cffd2a..718158f 100644 --- a/chrome/browser/chromeos/dom_ui/language_options_util.h +++ b/chrome/browser/chromeos/dom_ui/language_options_util.h @@ -15,7 +15,7 @@ class ListValue; -namespace { +namespace chromeos { // Returns an i18n-content value corresponding to |preference|. template <typename T> @@ -47,18 +47,8 @@ std::string GetTemplateDataMaxName(const T& preference, const char* prefix) { // Creates a Value object from the given value. Here we use function // overloading to handle string and integer preferences in // CreateMultipleChoiceList. -Value* CreateValue(const char* in_value) { - return Value::CreateStringValue(in_value); -} - -// See comments above. -Value* CreateValue(int in_value) { - return Value::CreateIntegerValue(in_value); -} - -} // namespace - -namespace chromeos { +Value* CreateValue(const char* in_value); +Value* CreateValue(int in_value); // Creates a multiple choice list from the given preference. template <typename T> |