diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-19 03:49:38 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-19 03:49:38 +0000 |
| commit | 864b1368516c110605addd725ad33613047f94b2 (patch) | |
| tree | 0f4d802f08b43df658ec45df351089e108f63b1b /chrome/browser/chromeos | |
| parent | 2803418949500717c4cbd1cb27fec8b03485e77a (diff) | |
| download | chromium_src-864b1368516c110605addd725ad33613047f94b2.zip chromium_src-864b1368516c110605addd725ad33613047f94b2.tar.gz chromium_src-864b1368516c110605addd725ad33613047f94b2.tar.bz2 | |
FBTF: Remove unneeded headers from base/ (part 6)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos')
| -rw-r--r-- | chrome/browser/chromeos/input_method/candidate_window.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/chromeos/login/cookie_fetcher.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/chromeos/login/google_authenticator.h | 2 | ||||
| -rw-r--r-- | chrome/browser/chromeos/options/wifi_config_view.h | 5 | ||||
| -rw-r--r-- | chrome/browser/chromeos/pipe_reader.cc | 17 | ||||
| -rw-r--r-- | chrome/browser/chromeos/pipe_reader.h | 18 | ||||
| -rw-r--r-- | chrome/browser/chromeos/pipe_reader_unittest.cc | 5 |
7 files changed, 28 insertions, 21 deletions
diff --git a/chrome/browser/chromeos/input_method/candidate_window.cc b/chrome/browser/chromeos/input_method/candidate_window.cc index c7b3e7e..a6fd344 100644 --- a/chrome/browser/chromeos/input_method/candidate_window.cc +++ b/chrome/browser/chromeos/input_method/candidate_window.cc @@ -14,7 +14,6 @@ #include "app/resource_bundle.h" #include "base/at_exit.h" #include "base/command_line.h" -#include "base/file_path.h" #include "base/logging.h" #include "base/observer_list.h" #include "base/path_service.h" diff --git a/chrome/browser/chromeos/login/cookie_fetcher.cc b/chrome/browser/chromeos/login/cookie_fetcher.cc index 48c7dec..0ea3c74 100644 --- a/chrome/browser/chromeos/login/cookie_fetcher.cc +++ b/chrome/browser/chromeos/login/cookie_fetcher.cc @@ -5,7 +5,6 @@ #include "chrome/browser/chromeos/login/cookie_fetcher.h" #include "base/command_line.h" -#include "base/file_path.h" #include "base/path_service.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/chromeos/login/client_login_response_handler.h" diff --git a/chrome/browser/chromeos/login/google_authenticator.h b/chrome/browser/chromeos/login/google_authenticator.h index 155679c..8ddc137 100644 --- a/chrome/browser/chromeos/login/google_authenticator.h +++ b/chrome/browser/chromeos/login/google_authenticator.h @@ -10,7 +10,6 @@ #include <vector> #include "base/basictypes.h" -#include "base/file_path.h" #include "base/gtest_prod_util.h" #include "base/ref_counted.h" #include "chrome/browser/chromeos/cros/cros_library.h" @@ -30,7 +29,6 @@ class GoogleAuthenticatorTest; class LoginStatusConsumer; class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer { - public: explicit GoogleAuthenticator(LoginStatusConsumer* consumer); virtual ~GoogleAuthenticator(); diff --git a/chrome/browser/chromeos/options/wifi_config_view.h b/chrome/browser/chromeos/options/wifi_config_view.h index 6dbe94b..1fbae69 100644 --- a/chrome/browser/chromeos/options/wifi_config_view.h +++ b/chrome/browser/chromeos/options/wifi_config_view.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -8,7 +8,6 @@ #include <string> -#include "base/file_path.h" #include "base/gtest_prod_util.h" #include "base/string16.h" #include "chrome/browser/chromeos/cros/network_library.h" @@ -20,6 +19,8 @@ #include "views/controls/textfield/textfield.h" #include "views/view.h" +class FilePath; + namespace chromeos { class NetworkConfigView; diff --git a/chrome/browser/chromeos/pipe_reader.cc b/chrome/browser/chromeos/pipe_reader.cc index 2ed5e7c..8664e35 100644 --- a/chrome/browser/chromeos/pipe_reader.cc +++ b/chrome/browser/chromeos/pipe_reader.cc @@ -1,13 +1,28 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "chrome/browser/chromeos/pipe_reader.h" +#include <fcntl.h> +#include <sys/stat.h> +#include <sys/types.h> + +#include "base/file_path.h" #include "base/scoped_ptr.h" namespace chromeos { +PipeReader::PipeReader(const FilePath& pipe_name) + : pipe_(NULL), + pipe_name_(pipe_name.value()) { +} + +PipeReader::~PipeReader() { + if (pipe_) + fclose(pipe_); +} + std::string PipeReader::Read(const uint32 bytes_to_read) { scoped_array<char> buffer(new char[bytes_to_read]); if (pipe_ || (pipe_ = fopen(pipe_name_.c_str(), "r"))) { diff --git a/chrome/browser/chromeos/pipe_reader.h b/chrome/browser/chromeos/pipe_reader.h index 1ebe43b..821fe95 100644 --- a/chrome/browser/chromeos/pipe_reader.h +++ b/chrome/browser/chromeos/pipe_reader.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,16 +6,14 @@ #define CHROME_BROWSER_CHROMEOS_PIPE_READER_H_ #pragma once -#include <fcntl.h> #include <stdio.h> -#include <sys/stat.h> -#include <sys/types.h> #include <unistd.h> #include <string> #include "base/basictypes.h" -#include "base/file_path.h" + +class FilePath; namespace chromeos { @@ -30,14 +28,8 @@ namespace chromeos { class PipeReader { public: - explicit PipeReader(const FilePath& pipe_name) - : pipe_(NULL), - pipe_name_(pipe_name.value()) { - } - virtual ~PipeReader() { - if (pipe_) - fclose(pipe_); - } + explicit PipeReader(const FilePath& pipe_name); + virtual ~PipeReader(); // Reads data from the pipe up until either a '\n' or |bytes_to_read| bytes. virtual std::string Read(const uint32 bytes_to_read); diff --git a/chrome/browser/chromeos/pipe_reader_unittest.cc b/chrome/browser/chromeos/pipe_reader_unittest.cc index e745655..3646b30 100644 --- a/chrome/browser/chromeos/pipe_reader_unittest.cc +++ b/chrome/browser/chromeos/pipe_reader_unittest.cc @@ -1,10 +1,13 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "chrome/browser/chromeos/pipe_reader.h" #include <errno.h> +#include <fcntl.h> +#include <sys/stat.h> +#include <sys/types.h> #include "base/file_path.h" #include "base/safe_strerror_posix.h" |
